alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@iki.fi>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org, "Ryan Mallon" <rmallon@gmail.com>,
	"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
	"Alexander Sverdlin" <subaparts@yandex.ru>,
	"Liam Girdwood" <lrg@ti.com>,
	"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCH 5/6] ASoC: ep93xx: Add .owner to struct snd_soc_card
Date: Fri, 23 Dec 2011 10:19:40 +0200	[thread overview]
Message-ID: <20111223081940.GA2401@mwesterb-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <1324560097.10821.8.camel@phoenix>

On Thu, Dec 22, 2011 at 09:21:37PM +0800, Axel Lin wrote:
> Missed .owner of struct snd_soc_card will prevent the module from being
> removed from underneath its users.
> 
> Reported-by: Lothar Waßmann <LW@KARO-electronics.de>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Thanks!

Acked-by: Mika Westerberg <mika.westerberg@iki.fi>

> ---
>  sound/soc/ep93xx/edb93xx.c     |    1 +
>  sound/soc/ep93xx/simone.c      |    1 +
>  sound/soc/ep93xx/snappercl15.c |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/ep93xx/edb93xx.c b/sound/soc/ep93xx/edb93xx.c
> index 9f6fecd..bae5cbb 100644
> --- a/sound/soc/ep93xx/edb93xx.c
> +++ b/sound/soc/ep93xx/edb93xx.c
> @@ -75,6 +75,7 @@ static struct snd_soc_dai_link edb93xx_dai = {
>  
>  static struct snd_soc_card snd_soc_edb93xx = {
>  	.name		= "EDB93XX",
> +	.owner		= THIS_MODULE,
>  	.dai_link	= &edb93xx_dai,
>  	.num_links	= 1,
>  };
> diff --git a/sound/soc/ep93xx/simone.c b/sound/soc/ep93xx/simone.c
> index 1e00b33..dd99709 100644
> --- a/sound/soc/ep93xx/simone.c
> +++ b/sound/soc/ep93xx/simone.c
> @@ -34,6 +34,7 @@ static struct snd_soc_dai_link simone_dai = {
>  
>  static struct snd_soc_card snd_soc_simone = {
>  	.name		= "Sim.One",
> +	.owner		= THIS_MODULE,
>  	.dai_link	= &simone_dai,
>  	.num_links	= 1,
>  };
> diff --git a/sound/soc/ep93xx/snappercl15.c b/sound/soc/ep93xx/snappercl15.c
> index e97cd57..ccae34a 100644
> --- a/sound/soc/ep93xx/snappercl15.c
> +++ b/sound/soc/ep93xx/snappercl15.c
> @@ -93,6 +93,7 @@ static struct snd_soc_dai_link snappercl15_dai = {
>  
>  static struct snd_soc_card snd_soc_snappercl15 = {
>  	.name		= "Snapper CL15",
> +	.owner		= THIS_MODULE,
>  	.dai_link	= &snappercl15_dai,
>  	.num_links	= 1,
>  };
> -- 
> 1.7.5.4
> 
> 

  reply	other threads:[~2011-12-23  8:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 13:14 [PATCH 1/6] ASoC: atmel: Add .owner to struct snd_soc_card Axel Lin
2011-12-22 13:16 ` [PATCH 2/6] ASoC: au1x: " Axel Lin
2011-12-22 14:13   ` Mark Brown
2011-12-22 13:17 ` [PATCH 3/6] ASoC: blackfin: " Axel Lin
2011-12-31  6:33   ` Mike Frysinger
2011-12-22 13:19 ` [PATCH 4/6] ASoC: davinci: " Axel Lin
2011-12-22 13:21 ` [PATCH 5/6] ASoC: ep93xx: " Axel Lin
2011-12-23  8:19   ` Mika Westerberg [this message]
2011-12-22 13:23 ` [PATCH 6/6] ASoC: tegra: " Axel Lin
2011-12-22 14:13 ` [PATCH 1/6] ASoC: atmel: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111223081940.GA2401@mwesterb-mobl.ger.corp.intel.com \
    --to=mika.westerberg@iki.fi \
    --cc=LW@KARO-electronics.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=rmallon@gmail.com \
    --cc=subaparts@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).