From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangsu Park <sangsu@gmail.com>
Cc: sbkim73@samsung.com, alsa-devel@alsa-project.org, lrg@ti.com,
sangsu4u.park@samsung.com
Subject: Re: [PATCH] ASoC: Allocate PCM operations dynamically to support multiple DAIs
Date: Tue, 27 Dec 2011 10:34:02 +0000 [thread overview]
Message-ID: <20111227103401.GB2870@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CANh+=Y8HVjkChnMQLzHmGbpbxRu3wxqbUDp2SQ3SpQhpC-0oug@mail.gmail.com>
On Tue, Dec 27, 2011 at 04:49:46PM +0900, Sangsu Park wrote:
> > On Fri, Dec 23, 2011 at 10:37:51AM +0900, Sangbeom Kim wrote:
> + struct snd_pcm_ops *soc_pcm_ops = platform->driver->ops;
> struct snd_pcm *pcm;
> char new_name[64];
> int ret = 0, playback = 0, capture = 0;
>
> if (playback)
> - snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &soc_pcm_ops);
> + snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, soc_pcm_ops);
>
> if (capture)
> - snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &soc_pcm_ops);
> + snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, soc_pcm_ops);
> But, it seems to make mutex dead lock.
> When starting playback, it tells some messages.
We still need to use the indirections in the SoC ops in the same way as
we do at present so that the DAI drivers and DAPM get called as well.
next prev parent reply other threads:[~2011-12-27 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 7:49 [PATCH] ASoC: Allocate PCM operations dynamically to support multiple DAIs Sangsu Park
2011-12-27 10:34 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-27 8:06 Sangsu Park
2011-12-27 10:40 ` Mark Brown
2011-12-23 1:37 Sangbeom Kim
2011-12-23 9:42 ` Liam Girdwood
2011-12-23 10:21 ` Mark Brown
2011-12-23 10:24 ` Mark Brown
2011-12-23 0:26 Sangbeom Kim
2011-12-23 11:36 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111227103401.GB2870@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=sangsu4u.park@samsung.com \
--cc=sangsu@gmail.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).