From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
alsa-devel@alsa-project.org, Paul Bolle <pebolle@tiscali.nl>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
Date: Sun, 8 Jan 2012 20:15:46 -0800 [thread overview]
Message-ID: <20120109041545.GK29065@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1326079783.2951.1.camel@phoenix>
On Mon, Jan 09, 2012 at 11:29:43AM +0800, Axel Lin wrote:
> This reverts commit 739be96ab83755e10fd0c2b6a34c8a73254527f7 because it
> introduces below build warnings:
> drivers/misc/Kconfig:212: symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
> sound/soc/atmel/Kconfig:9: symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
> sound/soc/atmel/Kconfig:18: symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC
> config SND_ATMEL_SOC_SSC
> tristate
> depends on SND_ATMEL_SOC
> - select ATMEL_SSC
Why is this the best fix? It's not obvious to me that the dependency
from the machine driver to the ATMEL_SSC (rather than a select or
relying on the SSC driver sorting things out) is correct.
next prev parent reply other threads:[~2012-01-09 4:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 3:29 [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC" Axel Lin
2012-01-09 4:15 ` Mark Brown [this message]
2012-01-09 4:40 ` Axel Lin
2012-01-09 6:23 ` Mark Brown
2012-01-09 9:38 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109041545.GK29065@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=lrg@ti.com \
--cc=pebolle@tiscali.nl \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).