* [PATCH] ASoC: Fix recursive dependency due to select ATMEL_SSC in SND_ATMEL_SOC_SSC
@ 2012-01-09 9:39 Axel Lin
2012-01-09 22:38 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2012-01-09 9:39 UTC (permalink / raw)
To: alsa-devel; +Cc: Stephen Rothwell, Paul Bolle, Mark Brown, Liam Girdwood
commit 739be96 "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
introduces below build warnings:
drivers/misc/Kconfig:212:error: recursive dependency detected!
drivers/misc/Kconfig:212: symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
sound/soc/atmel/Kconfig:9: symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
sound/soc/atmel/Kconfig:18: symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC
SND_ATMEL_SOC_SSC needs ATMEL_SSC to pass compilation.
This patch removes the "select ATMEL_SSC" from SND_ATMEL_SOC_SSC to avoid above
warnings. And then ensures all the machine drivers that select SND_ATMEL_SOC_SSC
need to depend on ATMEL_SSC.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/atmel/Kconfig | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index a4d6742..72b09cf 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -9,7 +9,6 @@ config SND_ATMEL_SOC
config SND_ATMEL_SOC_SSC
tristate
depends on SND_ATMEL_SOC
- select ATMEL_SSC
help
Say Y or M if you want to add support for codecs the
ATMEL SSC interface. You will also needs to select the individual
@@ -27,7 +26,7 @@ config SND_AT91_SOC_SAM9G20_WM8731
config SND_AT91_SOC_AFEB9260
tristate "SoC Audio support for AFEB9260 board"
- depends on ARCH_AT91 && MACH_AFEB9260 && SND_ATMEL_SOC
+ depends on ATMEL_SSC && ARCH_AT91 && MACH_AFEB9260 && SND_ATMEL_SOC
select SND_ATMEL_SOC_SSC
select SND_SOC_TLV320AIC23
help
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Fix recursive dependency due to select ATMEL_SSC in SND_ATMEL_SOC_SSC
2012-01-09 9:39 [PATCH] ASoC: Fix recursive dependency due to select ATMEL_SSC in SND_ATMEL_SOC_SSC Axel Lin
@ 2012-01-09 22:38 ` Mark Brown
2012-01-10 5:00 ` Axel Lin
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2012-01-09 22:38 UTC (permalink / raw)
To: Axel Lin; +Cc: Stephen Rothwell, alsa-devel, Paul Bolle, Liam Girdwood
On Mon, Jan 09, 2012 at 05:39:18PM +0800, Axel Lin wrote:
> commit 739be96 "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
> introduces below build warnings:
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Fix recursive dependency due to select ATMEL_SSC in SND_ATMEL_SOC_SSC
2012-01-09 22:38 ` Mark Brown
@ 2012-01-10 5:00 ` Axel Lin
2012-01-10 5:23 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2012-01-10 5:00 UTC (permalink / raw)
To: Mark Brown; +Cc: Stephen Rothwell, alsa-devel, Paul Bolle, Liam Girdwood
2012/1/10 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Mon, Jan 09, 2012 at 05:39:18PM +0800, Axel Lin wrote:
>> commit 739be96 "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
>> introduces below build warnings:
>
> Applied, thanks.
Hi Mark,
I thought you already applied this one, but you did not.
You apply commit 10024e394 (ASoC: Fix build dependency for
SND_AT91_SOC_AFEB9260) instead.
Thus you need to apply the patch I sent yesterday
([PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC")
to fix recursive dependency detected warnings.
Sorry for the mess.
Regards,
Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Fix recursive dependency due to select ATMEL_SSC in SND_ATMEL_SOC_SSC
2012-01-10 5:00 ` Axel Lin
@ 2012-01-10 5:23 ` Mark Brown
2012-01-10 6:16 ` Axel Lin
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2012-01-10 5:23 UTC (permalink / raw)
To: Axel Lin; +Cc: Stephen Rothwell, alsa-devel, Paul Bolle, Liam Girdwood
On Tue, Jan 10, 2012 at 01:00:24PM +0800, Axel Lin wrote:
> I thought you already applied this one, but you did not.
> You apply commit 10024e394 (ASoC: Fix build dependency for
> SND_AT91_SOC_AFEB9260) instead.
Oh, gah. I've just dropped this patch.
> Thus you need to apply the patch I sent yesterday
> ([PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC")
> to fix recursive dependency detected warnings.
Please don't just refer to patches on the list unless it's under active
discussion or similar, send the patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Fix recursive dependency due to select ATMEL_SSC in SND_ATMEL_SOC_SSC
2012-01-10 5:23 ` Mark Brown
@ 2012-01-10 6:16 ` Axel Lin
0 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2012-01-10 6:16 UTC (permalink / raw)
To: Mark Brown; +Cc: Stephen Rothwell, alsa-devel, Paul Bolle, Liam Girdwood
2012/1/10 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Tue, Jan 10, 2012 at 01:00:24PM +0800, Axel Lin wrote:
>
>> I thought you already applied this one, but you did not.
>> You apply commit 10024e394 (ASoC: Fix build dependency for
>> SND_AT91_SOC_AFEB9260) instead.
>
> Oh, gah. I've just dropped this patch.
Ok.
I found you apply the correct patch now in your for-3.4 branch.
But it is strange that the commit 53aa7af780 in your for-3.4 branch is
different from the patch I sent.
I'll resent it again now.
Regards,
Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-10 6:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09 9:39 [PATCH] ASoC: Fix recursive dependency due to select ATMEL_SSC in SND_ATMEL_SOC_SSC Axel Lin
2012-01-09 22:38 ` Mark Brown
2012-01-10 5:00 ` Axel Lin
2012-01-10 5:23 ` Mark Brown
2012-01-10 6:16 ` Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).