From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: Return proper error if i2c_add_driver fails
Date: Tue, 10 Jan 2012 18:53:40 +0000 [thread overview]
Message-ID: <20120110185340.GH7164@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1326185690.28549.1.camel@phoenix>
On Tue, Jan 10, 2012 at 04:54:50PM +0800, Axel Lin wrote:
> #endif
> - return 0;
> + return ret;
No, if we've got multiple bus types we do ignore the error in case one
of the buses failed (and if we were doing this then we'd need to clean
up the thing that successfully registered). If we've not got multiple
bus types then the ifdefs shouldn't be there and we should just have a
trivial call to the registration function.
prev parent reply other threads:[~2012-01-10 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 8:54 [PATCH] ASoC: Return proper error if i2c_add_driver fails Axel Lin
2012-01-10 18:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110185340.GH7164@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).