From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Fabio Estevam <festevam@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Dong Aisheng <b29396@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: duplicated test in sound/soc/codecs/sgtl5000.c
Date: Thu, 12 Jan 2012 22:28:02 +0000 [thread overview]
Message-ID: <20120112222759.GA23716@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201122210520.25187@pl-59034.rocq.inria.fr>
On Thu, Jan 12, 2012 at 10:13:24PM +0100, Julia Lawall wrote:
> There is a duplicated test in the function sgtl5000_restore_regs in the
> file sound/soc/codecs/sgtl5000.c:
> /* this regs depends on the others */
> if (reg == SGTL5000_CHIP_ANA_POWER ||
> reg == SGTL5000_CHIP_CLK_CTRL ||
> reg == SGTL5000_CHIP_LINREG_CTRL ||
> reg == SGTL5000_CHIP_LINE_OUT_CTRL ||
> reg == SGTL5000_CHIP_CLK_CTRL)
> continue;
> I don't know if some constant other than SGTL5000_CHIP_CLK_CTRL should be
> tested, or if the second test should just be deleted.
Adding the people who've been working on the driver. Generally this is
a good idea when reporting issues like this.
next prev parent reply other threads:[~2012-01-12 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 21:13 duplicated test in sound/soc/codecs/sgtl5000.c Julia Lawall
2012-01-12 22:28 ` Mark Brown [this message]
2012-01-13 6:21 ` Dong Aisheng-B29396
2012-01-13 6:37 ` Mark Brown
2012-01-13 6:49 ` Dong Aisheng-B29396
2012-01-13 8:40 ` Zeng Zhaoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112222759.GA23716@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=b29396@freescale.com \
--cc=festevam@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=lrg@ti.com \
--cc=shawn.guo@linaro.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).