duplicated test in sound/soc/codecs/sgtl5000.c

duplicated test in sound/soc/codecs/sgtl5000.c

[Julia Lawall]

There is a duplicated test in the function sgtl5000_restore_regs in the 
file sound/soc/codecs/sgtl5000.c:

                /* this regs depends on the others */
                 if (reg == SGTL5000_CHIP_ANA_POWER ||
                         reg == SGTL5000_CHIP_CLK_CTRL ||
                         reg == SGTL5000_CHIP_LINREG_CTRL ||
                         reg == SGTL5000_CHIP_LINE_OUT_CTRL ||
                         reg == SGTL5000_CHIP_CLK_CTRL)
                         continue;

I don't know if some constant other than SGTL5000_CHIP_CLK_CTRL should be 
tested, or if the second test should just be deleted.

julia

Re: duplicated test in sound/soc/codecs/sgtl5000.c

[Mark Brown]

On Thu, Jan 12, 2012 at 10:13:24PM +0100, Julia Lawall wrote:
> There is a duplicated test in the function sgtl5000_restore_regs in the  
> file sound/soc/codecs/sgtl5000.c:

>                /* this regs depends on the others */
>                 if (reg == SGTL5000_CHIP_ANA_POWER ||
>                         reg == SGTL5000_CHIP_CLK_CTRL ||
>                         reg == SGTL5000_CHIP_LINREG_CTRL ||
>                         reg == SGTL5000_CHIP_LINE_OUT_CTRL ||
>                         reg == SGTL5000_CHIP_CLK_CTRL)
>                         continue;

> I don't know if some constant other than SGTL5000_CHIP_CLK_CTRL should be 
> tested, or if the second test should just be deleted.

Adding the people who've been working on the driver.  Generally this is
a good idea when reporting issues like this.

Re: duplicated test in sound/soc/codecs/sgtl5000.c

[Dong Aisheng-B29396]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Friday, January 13, 2012 6:28 AM
> To: Julia Lawall; Fabio Estevam; Wolfram Sang; Dong Aisheng-B29396; Shawn Guo
> Cc: lrg@ti.com; alsa-devel@alsa-project.org
> Subject: Re: duplicated test in sound/soc/codecs/sgtl5000.c
> Importance: High
> 
> On Thu, Jan 12, 2012 at 10:13:24PM +0100, Julia Lawall wrote:
> > There is a duplicated test in the function sgtl5000_restore_regs in
> > the file sound/soc/codecs/sgtl5000.c:
> 
> >                /* this regs depends on the others */
> >                 if (reg == SGTL5000_CHIP_ANA_POWER ||
> >                         reg == SGTL5000_CHIP_CLK_CTRL ||
> >                         reg == SGTL5000_CHIP_LINREG_CTRL ||
> >                         reg == SGTL5000_CHIP_LINE_OUT_CTRL ||
> >                         reg == SGTL5000_CHIP_CLK_CTRL)
> >                         continue;
> 
> > I don't know if some constant other than SGTL5000_CHIP_CLK_CTRL should
> > be tested, or if the second test should just be deleted.
> 
> Adding the people who've been working on the driver.  Generally this is a good
> idea when reporting issues like this.
Cc Zhaoming.

Looking at the code, I guess it's a typo error and the second check should be
SGTL5000_CHIP_REF_CTRL since it will restore it again.

Hi Mark,
Since zhaoming leaved Freescale a few month ago,
would you mind if I send a patch to add my name under MODULE_AHTOER as
Co-maintainer for this driver and update Zhaoming's email address?

Regards
Dong Aisheng

Re: duplicated test in sound/soc/codecs/sgtl5000.c

[Mark Brown]

On Fri, Jan 13, 2012 at 06:21:00AM +0000, Dong Aisheng-B29396 wrote:

> Since zhaoming leaved Freescale a few month ago,
> would you mind if I send a patch to add my name under MODULE_AHTOER as
> Co-maintainer for this driver and update Zhaoming's email address?

Typically the way this ends up getting done is that the MODULE_AUTHOR is
left to bitrot but a MAINTAINERS file entry is added which reflects
who's actually working on the driver.  Comments also get added
sometimes.  But really I don't mind.

Re: duplicated test in sound/soc/codecs/sgtl5000.c

[Dong Aisheng-B29396]

> -----Original Message-----
> From: alsa-devel-bounces@alsa-project.org [mailto:alsa-devel-bounces@alsa-
> project.org] On Behalf Of Mark Brown
> Sent: Friday, January 13, 2012 2:38 PM
> To: Dong Aisheng-B29396
> Cc: alsa-devel@alsa-project.org; Wolfram Sang; Julia Lawall;
> zengzm.kernel@gmail.com; Shawn Guo; Fabio Estevam; lrg@ti.com
> Subject: Re: [alsa-devel] duplicated test in sound/soc/codecs/sgtl5000.c
> Importance: High
> 
> On Fri, Jan 13, 2012 at 06:21:00AM +0000, Dong Aisheng-B29396 wrote:
> 
> > Since zhaoming leaved Freescale a few month ago, would you mind if I
> > send a patch to add my name under MODULE_AHTOER as Co-maintainer for
> > this driver and update Zhaoming's email address?
> 
> Typically the way this ends up getting done is that the MODULE_AUTHOR is left to
> bitrot but a MAINTAINERS file entry is added which reflects who's actually
> working on the driver.  Comments also get added sometimes.
>
Agree. Thanks.

> But really I don't mind.
>

Regards
Dong Aisheng

Re: duplicated test in sound/soc/codecs/sgtl5000.c

[Zeng Zhaoming]

On Fri 2012-01-13 06:21:00, Dong Aisheng-B29396 wrote:
> > -----Original Message-----
> > From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> > Sent: Friday, January 13, 2012 6:28 AM
> > To: Julia Lawall; Fabio Estevam; Wolfram Sang; Dong Aisheng-B29396; Shawn Guo
> > Cc: lrg@ti.com; alsa-devel@alsa-project.org
> > Subject: Re: duplicated test in sound/soc/codecs/sgtl5000.c
> > Importance: High
> > 
> > On Thu, Jan 12, 2012 at 10:13:24PM +0100, Julia Lawall wrote:
> > > There is a duplicated test in the function sgtl5000_restore_regs in
> > > the file sound/soc/codecs/sgtl5000.c:
> > 
> > >                /* this regs depends on the others */
> > >                 if (reg == SGTL5000_CHIP_ANA_POWER ||
> > >                         reg == SGTL5000_CHIP_CLK_CTRL ||
> > >                         reg == SGTL5000_CHIP_LINREG_CTRL ||
> > >                         reg == SGTL5000_CHIP_LINE_OUT_CTRL ||
> > >                         reg == SGTL5000_CHIP_CLK_CTRL)
> > >                         continue;
> > 
> > > I don't know if some constant other than SGTL5000_CHIP_CLK_CTRL should
> > > be tested, or if the second test should just be deleted.
> > 
> > Adding the people who've been working on the driver.  Generally this is a good
> > idea when reporting issues like this.
> Cc Zhaoming.
> 
> Looking at the code, I guess it's a typo error and the second check should be
> SGTL5000_CHIP_REF_CTRL since it will restore it again.

Hi, Aisheng and Julia:
    Yes, a typo, I will send patch to correct it.

    And Julia, the five regs list there since it should be restore in a particular
order, the order is:
    1. SGTL5000_CHIP_CLK_CTRL MCLK_FREQ bits (1:0) should be restore after 
    SGTL5000_CHIP_ANA_POWER PLL bits set.
    2. SGTL5000_CHIP_LINREG_CTRL should be set before SGTL5000_CHIP_ANA_POWER LINREG_D
     restored.
    3. SGTL5000_CHIP_REF_CTRL controls Analog Ground Voltage, I prefer to resotre it
    after SGTL5000_CHIP_ANA_POWER restored.
    4. for SGTL5000_CHIP_LINE_OUT_CTRL, I forget the real reason, Aisheng, can you help
    verify line-out if remove it?
> 
> Hi Mark,
> Since zhaoming leaved Freescale a few month ago,
> would you mind if I send a patch to add my name under MODULE_AHTOER as
> Co-maintainer for this driver and update Zhaoming's email address?
> 
> Regards
> Dong Aisheng