[PATCH] ASoC: omap-mcpdm: Set constraint for 24 msb

[PATCH] ASoC: omap-mcpdm: Set constraint for 24 msb

[Peter Ujfalusi]

OMAP McPDM supports 24 msb in the 32 bit sample.
Make sure that applications get this information.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 sound/soc/omap/omap-mcpdm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc/omap/omap-mcpdm.c
index 0e25df4..50d758a 100644
--- a/sound/soc/omap/omap-mcpdm.c
+++ b/sound/soc/omap/omap-mcpdm.c
@@ -265,6 +265,8 @@ static int omap_mcpdm_dai_startup(struct snd_pcm_substream *substream,
 
 	mutex_lock(&mcpdm->mutex);
 
+	snd_pcm_hw_constraint_msbits(substream->runtime, 0, 32, 24);
+
 	if (!dai->active) {
 		/* Enable watch dog for ES above ES 1.0 to avoid saturation */
 		if (omap_rev() != OMAP4430_REV_ES1_0) {
-- 
1.7.8.3

Re: [PATCH] ASoC: omap-mcpdm: Set constraint for 24 msb

[Mark Brown]

On Sat, Jan 14, 2012 at 05:16:43PM +0100, Peter Ujfalusi wrote:
> OMAP McPDM supports 24 msb in the 32 bit sample.
> Make sure that applications get this information.

This is actually a pretty widespread configuration for hardware - I'd
guess most devices that support 32 bit DAI formats don't actually use
all 32 bits.  If this is really useful to applications we should add a
framework feature letting drivers just set a number rather than adding
code individual drivers, I'll send a patch shortly adding a feature for
this.