alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: alsa-devel@alsa-project.org,
	Javier Martin <javier.martin@vista-silicon.com>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2] ASoC: tlv320aic32x4: always enable dividers
Date: Wed, 18 Jan 2012 10:50:54 +0000	[thread overview]
Message-ID: <20120118105054.GE8732@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1326883739-8148-1-git-send-email-w.sang@pengutronix.de>

On Wed, Jan 18, 2012 at 11:48:58AM +0100, Wolfram Sang wrote:

> +		/* Switch on PLL */
> +		snd_soc_update_bits(codec, AIC32X4_PLLPR,
> +				    AIC32X4_PLLEN, AIC32X4_PLLEN);

Looking at this code it looks a lot like these ought to be supplies, not
that that needs to be fixed right now.

  parent reply	other threads:[~2012-01-18 10:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 10:48 [PATCH 1/2] ASoC: tlv320aic32x4: always enable dividers Wolfram Sang
2012-01-18 10:48 ` [PATCH 2/2] ASoC: tlv320aic32x4: always enable analouge block Wolfram Sang
2012-01-18 15:29   ` javier Martin
2012-01-18 10:50 ` Mark Brown [this message]
2012-01-18 11:14   ` [PATCH 1/2] ASoC: tlv320aic32x4: always enable dividers Wolfram Sang
2012-01-18 11:24     ` Mark Brown
2012-01-18 15:29 ` javier Martin
2012-01-18 17:55 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120118105054.GE8732@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=javier.martin@vista-silicon.com \
    --cc=lrg@ti.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).