From: Wolfram Sang <w.sang@pengutronix.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
Javier Martin <javier.martin@vista-silicon.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2] ASoC: tlv320aic32x4: always enable dividers
Date: Wed, 18 Jan 2012 12:14:24 +0100 [thread overview]
Message-ID: <20120118111424.GD2559@pengutronix.de> (raw)
In-Reply-To: <20120118105054.GE8732@opensource.wolfsonmicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 987 bytes --]
On Wed, Jan 18, 2012 at 10:50:54AM +0000, Mark Brown wrote:
> On Wed, Jan 18, 2012 at 11:48:58AM +0100, Wolfram Sang wrote:
>
> > + /* Switch on PLL */
> > + snd_soc_update_bits(codec, AIC32X4_PLLPR,
> > + AIC32X4_PLLEN, AIC32X4_PLLEN);
>
> Looking at this code it looks a lot like these ought to be supplies, not
> that that needs to be fixed right now.
A lot of things need to be fixed in that driver I think. I am still figuring
what incremental set of steps would make sense. Sadly, I am not an ASoC
expert and I won't have endless time for this task, but at least there
is another driver [1] as a working reference. I'll see what I can come
up with in that time, probably reg-caching is next.
Regards,
Wolfram
[1] http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-06/msg07236.html
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-01-18 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 10:48 [PATCH 1/2] ASoC: tlv320aic32x4: always enable dividers Wolfram Sang
2012-01-18 10:48 ` [PATCH 2/2] ASoC: tlv320aic32x4: always enable analouge block Wolfram Sang
2012-01-18 15:29 ` javier Martin
2012-01-18 10:50 ` [PATCH 1/2] ASoC: tlv320aic32x4: always enable dividers Mark Brown
2012-01-18 11:14 ` Wolfram Sang [this message]
2012-01-18 11:24 ` Mark Brown
2012-01-18 15:29 ` javier Martin
2012-01-18 17:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118111424.GD2559@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=javier.martin@vista-silicon.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).