alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Eikum <aeikum@codeweavers.com>
To: alsa-devel <alsa-devel@alsa-project.org>
Subject: [alsa-lib PATCH] Document strdup allocation in snd_card_get_name family
Date: Wed, 18 Jan 2012 08:58:08 -0600	[thread overview]
Message-ID: <20120118145808.GR24575@foghorn.codeweavers.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

This was spotted by Jörg Höhle on the wine-patches ML.

Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
---

I noticed my documentation patches haven't been making their way into
alsa-lib.git. Am I submitting these wrong? I added the SOB line above,
although I notice not all patches that get into ALSA have it. On the
other hand, alsa-lib.git hasn't been changed since November so perhaps
my patches are sitting in someone's tree waiting to be pushed :)

Please let me know if I can help get these in.

 src/control/cards.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)


[-- Attachment #2: 0001-Document-strdup-allocation-in-snd_card_get_name-fami.patch --]
[-- Type: text/x-patch, Size: 922 bytes --]

diff --git a/src/control/cards.c b/src/control/cards.c
index 0bb8f86..b528e33 100644
--- a/src/control/cards.c
+++ b/src/control/cards.c
@@ -166,6 +166,9 @@ int snd_card_get_index(const char *string)
  * \param card Card number
  * \param name Result - card name corresponding to card number
  * \result zero if success, otherwise a negative error code
+ *
+ * The value returned in name is allocated with strdup and should be
+ * freed when no longer used.
  */
 int snd_card_get_name(int card, char **name)
 {
@@ -193,6 +196,9 @@ int snd_card_get_name(int card, char **name)
  * \param card Card number
  * \param name Result - card long name corresponding to card number
  * \result zero if success, otherwise a negative error code
+ *
+ * The value returned in name is allocated with strdup and should be
+ * freed when no longer used.
  */
 int snd_card_get_longname(int card, char **name)
 {

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2012-01-18 14:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 14:58 Andrew Eikum [this message]
2012-01-19 11:41 ` [alsa-lib PATCH] Document strdup allocation in snd_card_get_name family Takashi Iwai
2012-01-19 14:48   ` Andrew Eikum
2012-01-19 19:41     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120118145808.GR24575@foghorn.codeweavers.com \
    --to=aeikum@codeweavers.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).