[alsa-lib PATCH] Document strdup allocation in snd_card_get_name family

[alsa-lib PATCH] Document strdup allocation in snd_card_get_name family

[Andrew Eikum]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

This was spotted by Jörg Höhle on the wine-patches ML.

Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
---

I noticed my documentation patches haven't been making their way into
alsa-lib.git. Am I submitting these wrong? I added the SOB line above,
although I notice not all patches that get into ALSA have it. On the
other hand, alsa-lib.git hasn't been changed since November so perhaps
my patches are sitting in someone's tree waiting to be pushed :)

Please let me know if I can help get these in.

 src/control/cards.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)


[-- Attachment #2: 0001-Document-strdup-allocation-in-snd_card_get_name-fami.patch --]
[-- Type: text/x-patch, Size: 922 bytes --]

diff --git a/src/control/cards.c b/src/control/cards.c
index 0bb8f86..b528e33 100644
--- a/src/control/cards.c
+++ b/src/control/cards.c
@@ -166,6 +166,9 @@ int snd_card_get_index(const char *string)
  * \param card Card number
  * \param name Result - card name corresponding to card number
  * \result zero if success, otherwise a negative error code
+ *
+ * The value returned in name is allocated with strdup and should be
+ * freed when no longer used.
  */
 int snd_card_get_name(int card, char **name)
 {
@@ -193,6 +196,9 @@ int snd_card_get_name(int card, char **name)
  * \param card Card number
  * \param name Result - card long name corresponding to card number
  * \result zero if success, otherwise a negative error code
+ *
+ * The value returned in name is allocated with strdup and should be
+ * freed when no longer used.
  */
 int snd_card_get_longname(int card, char **name)
 {

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [alsa-lib PATCH] Document strdup allocation in snd_card_get_name family

[Takashi Iwai]

At Wed, 18 Jan 2012 08:58:08 -0600,
Andrew Eikum wrote:
> 
> This was spotted by Jörg Höhle on the wine-patches ML.
> 
> Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
> ---
> 
> I noticed my documentation patches haven't been making their way into
> alsa-lib.git. Am I submitting these wrong? I added the SOB line above,
> although I notice not all patches that get into ALSA have it. On the
> other hand, alsa-lib.git hasn't been changed since November so perhaps
> my patches are sitting in someone's tree waiting to be pushed :)

Sorry, I simply overlooked your patches since they have been posted
during my vacation.  Now all patches are committed and pushed out.

> Please let me know if I can help get these in.

Please add maintainers to Cc.  Also, at the next time, try to create
patches directly applicable via git-am.  I had to apply and fix them
manually.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-lib PATCH] Document strdup allocation in snd_card_get_name family

[Andrew Eikum]

On Thu, Jan 19, 2012 at 12:41:57PM +0100, Takashi Iwai wrote:
> At Wed, 18 Jan 2012 08:58:08 -0600,
> Andrew Eikum wrote:
> > 
> > This was spotted by Jörg Höhle on the wine-patches ML.
> > 
> > Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
> > ---
> > 
> > I noticed my documentation patches haven't been making their way into
> > alsa-lib.git. Am I submitting these wrong? I added the SOB line above,
> > although I notice not all patches that get into ALSA have it. On the
> > other hand, alsa-lib.git hasn't been changed since November so perhaps
> > my patches are sitting in someone's tree waiting to be pushed :)
> 
> Sorry, I simply overlooked your patches since they have been posted
> during my vacation.  Now all patches are committed and pushed out.
> 

Great, thank you!

> > Please let me know if I can help get these in.
> 
> Please add maintainers to Cc.  Also, at the next time, try to create
> patches directly applicable via git-am.  I had to apply and fix them
> manually.
> 

Hm, that's strange.  I use format-patch to generate the mail files
which I then send out with mutt, and they work fine on my end. I
pulled the mail file for the strdup patch as delivered by alsa-devel
off our mail server and imported it with git-am without any issue at
all. What do the mail files look like when they reach you?

Here's the mail as it arrived in my Maildir, which imports fine with
git-am 1.7.8.3:
<http://pastebin.com/C4R08Xj3>

Andrew
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-lib PATCH] Document strdup allocation in snd_card_get_name family

[Takashi Iwai]

At Thu, 19 Jan 2012 08:48:45 -0600,
Andrew Eikum wrote:
> 
> On Thu, Jan 19, 2012 at 12:41:57PM +0100, Takashi Iwai wrote:
> > At Wed, 18 Jan 2012 08:58:08 -0600,
> > Andrew Eikum wrote:
> > > 
> > > This was spotted by Jörg Höhle on the wine-patches ML.
> > > 
> > > Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
> > > ---
> > > 
> > > I noticed my documentation patches haven't been making their way into
> > > alsa-lib.git. Am I submitting these wrong? I added the SOB line above,
> > > although I notice not all patches that get into ALSA have it. On the
> > > other hand, alsa-lib.git hasn't been changed since November so perhaps
> > > my patches are sitting in someone's tree waiting to be pushed :)
> > 
> > Sorry, I simply overlooked your patches since they have been posted
> > during my vacation.  Now all patches are committed and pushed out.
> > 
> 
> Great, thank you!
> 
> > > Please let me know if I can help get these in.
> > 
> > Please add maintainers to Cc.  Also, at the next time, try to create
> > patches directly applicable via git-am.  I had to apply and fix them
> > manually.
> > 
> 
> Hm, that's strange.  I use format-patch to generate the mail files
> which I then send out with mutt, and they work fine on my end. I
> pulled the mail file for the strdup patch as delivered by alsa-devel
> off our mail server and imported it with git-am without any issue at
> all. What do the mail files look like when they reach you?
> 
> Here's the mail as it arrived in my Maildir, which imports fine with
> git-am 1.7.8.3:
> <http://pastebin.com/C4R08Xj3>

Did you really create it via git-format-patch?  It won't create any
attachment usually but the patch must be embedded.
If it's not manageable, try git-send-email instead.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel