From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH v5] ASoC: Apply msbits constraint for sample size bigger than the msbits
Date: Wed, 18 Jan 2012 15:29:05 +0000 [thread overview]
Message-ID: <20120118152905.GP8732@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1326899114-26979-1-git-send-email-peter.ujfalusi@ti.com>
On Wed, Jan 18, 2012 at 04:05:14PM +0100, Peter Ujfalusi wrote:
> Converted to use while loop.
> We run the loop as long as the sample size is bigger than the requested
> msbits.
I'm not sure this is actually a legibility improvement, if anything it's
probably less clear than the original as now the setup of the loop is
spread even further around the function.
> Most of the drivers require 24/32 configuration, so not point of looping
> for smaller sample sizes.
Performance isn't really a concern in this path unless we do something
totally insane. Thinking time on the part of the reader needs to be
considered too...
next prev parent reply other threads:[~2012-01-18 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 15:05 [PATCH v5] ASoC: Apply msbits constraint for sample size bigger than the msbits Peter Ujfalusi
2012-01-18 15:29 ` Mark Brown [this message]
2012-01-18 16:43 ` Peter Ujfalusi
2012-01-18 17:46 ` Mark Brown
2012-01-19 8:27 ` Peter Ujfalusi
2012-01-19 10:48 ` Mark Brown
2012-01-19 12:40 ` Peter Ujfalusi
2012-01-19 15:39 ` Mark Brown
2012-01-18 15:35 ` Clemens Ladisch
2012-01-18 15:43 ` Peter Ujfalusi
2012-01-18 15:49 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118152905.GP8732@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).