From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 00/10] patch set about the MXS-DMA Date: Thu, 19 Jan 2012 10:45:13 +0100 Message-ID: <20120119094513.GB2630@pengutronix.de> References: <1326953767-24155-1-git-send-email-b32955@freescale.com> <20120119091034.GH2247@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i9LlY+UWpKt15+FH" Return-path: Content-Disposition: inline In-Reply-To: <20120119091034.GH2247@S2101-09.ap.freescale.net> Sender: linux-mmc-owner@vger.kernel.org To: Shawn Guo Cc: Huang Shijie , vinod.koul@intel.com, artem.bityutskiy@intel.com, shijie8@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, LW@KARO-electronics.de, alsa-devel@alsa-project.org, b29396@freescale.com List-Id: alsa-devel@alsa-project.org --i9LlY+UWpKt15+FH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > [2] patch 6 ~ patch 10: rewrite the last parameter of mxs_dma_prep_slav= e_sg(). >=20 > For the sake of bitsec, at least patches #7 and #8 need to be one patch. > That said, if I apply the series and then check out the commit at patch > #7, you need to all mxs-dma client drivers, mxs-mmc, gpmi do not break. I'd say patch 6-10 should be squashed, simply. My personal preference is to change #9 to simply read the register when needed and do not expand the struct, but this is a minor thing. Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --i9LlY+UWpKt15+FH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk8X5ikACgkQD27XaX1/VRs1iQCfelj5s+udWkk+1mkd1T8lCB82 3T8An1b3bxZeJWRtXbyP/0da2ymYEMRs =PAKK -----END PGP SIGNATURE----- --i9LlY+UWpKt15+FH--