From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: javier Martin <javier.martin@vista-silicon.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Add external amplifier controls for Visstrim_M10.
Date: Thu, 19 Jan 2012 17:59:13 +0000 [thread overview]
Message-ID: <20120119175913.GL3178@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACKLOr10BtcBjRGYjU7H+6tBYwWZf4h15O=bNU2gxvGU9re0qQ@mail.gmail.com>
On Thu, Jan 19, 2012 at 05:37:46PM +0100, javier Martin wrote:
> On 19 January 2012 16:45, Mark Brown
> >> + ret = mxc_gpio_setup_multiple_pins(mx27vis_amp_pins,
> >> + ARRAY_SIZE(mx27vis_amp_pins), "MX27VIS_AMP");
> >> + if (ret) {
> >> + printk(KERN_ERR "ASoC: unable to setup gpios\n");
> >> + platform_device_put(mx27vis_aic32x4_snd_device);
> >> + }
> > This looks awfully like it should be arch/arm code except it looks like
> > it also munges in the gpio_request. Odd.
> This is a doubt I had. I could also use board specific file to request
> these gpios and then use some platform data to tell the driver what
> GPIOS must be used.
> However, as those gpios are fixed for all Visstrim_M10 boards I
> considered it didn't worth it.
> On the other hand, if you think it's cleaner that way I can do that.
I think this is just the arch being non-standard.
next prev parent reply other threads:[~2012-01-19 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 14:53 [PATCH] ASoC: Add external amplifier controls for Visstrim_M10 Javier Martin
2012-01-19 15:45 ` Mark Brown
2012-01-19 16:37 ` javier Martin
2012-01-19 17:59 ` Mark Brown [this message]
2012-01-19 16:52 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119175913.GL3178@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=javier.martin@vista-silicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).