From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Date: Thu, 26 Jan 2012 12:25:08 +0100 Message-ID: <20120126112508.GC2611@pengutronix.de> References: <1326362117-29371-1-git-send-email-Julia.Lawall@lip6.fr> <7FE21149F4667147B645348EC605788508FBDB@039-SN2MPN1-013.039d.mgd.msft.net> <20120124202203.GD1135@opensource.wolfsonmicro.com> <20120126110506.GB2611@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6180756182198617337==" Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [92.198.50.35]) by alsa0.perex.cz (Postfix) with ESMTP id 76E2E103C68 for ; Thu, 26 Jan 2012 12:25:10 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Julia Lawall Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Mark Brown , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dong Aisheng-B29396 , Liam Girdwood List-Id: alsa-devel@alsa-project.org --===============6180756182198617337== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aT9PWwzfKXlsBJM1" Content-Disposition: inline --aT9PWwzfKXlsBJM1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 26, 2012 at 12:21:35PM +0100, Julia Lawall wrote: > On Thu, 26 Jan 2012, Wolfram Sang wrote: >=20 > >>@@ -666,18 +666,19 @@ static int mxs_saif_probe(struct platform_device = *pdev) > >> goto failed_get_resource; > >> } > >> > >>- if (!request_mem_region(iores->start, resource_size(iores), > >>- "mxs-saif")) { > >>+ if (!devm_request_mem_region(&pdev->dev, iores->start, > >>+ resource_size(iores), "mxs-saif")) { > >> dev_err(&pdev->dev, "request_mem_region failed\n"); > >> ret =3D -EBUSY; > >> goto failed_get_resource; > >> } > >> > >>- saif->base =3D ioremap(iores->start, resource_size(iores)); > >>+ saif->base =3D devm_ioremap(&pdev->dev, iores->start, > >>+ resource_size(iores)); > > > >devm_request_and_ioremap() to save even more code? >=20 > I didn't do that because apparently it is not yet in a release? I > have another for introducing those... It got included in the last merge window: commit 72f8c0bfa0de64c68ee59f40eb9b2683bffffbb0 Author: Wolfram Sang Date: Tue Oct 25 15:16:47 2011 +0200 lib: devres: add convenience function to remap a resource =2E.. --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --aT9PWwzfKXlsBJM1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk8hOBQACgkQD27XaX1/VRuqggCeL/cDl3a3W8oKMN9+qzPI7I10 BJQAoJpEeUE2sX6q7awo22FxowBHA732 =Yg4u -----END PGP SIGNATURE----- --aT9PWwzfKXlsBJM1-- --===============6180756182198617337== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6180756182198617337==--