From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: M R Swami Reddy <MR.Swami.Reddy@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Girdwood, Liam" <lrg@ti.com>
Subject: Re: [PATCH ] ASoC: Add support for TI LM49453 Audio codec
Date: Fri, 3 Feb 2012 13:55:45 +0000 [thread overview]
Message-ID: <20120203135544.GP3151@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F2BE22A.7070006@nsc.com>
[-- Attachment #1.1: Type: text/plain, Size: 761 bytes --]
On Fri, Feb 03, 2012 at 07:03:30PM +0530, M R Swami Reddy wrote:
> Mark Brown wrote:
> >On Fri, Feb 03, 2012 at 04:19:00AM -0800, Reddy, MR Swami wrote:
> >>Setting CHIP_EN bit as '0'. In the _STANDBY mode, CHIP_EN bit setting
> >>not needed and will remove in the next patch.
> >This also sounds broken, as I repeatedly said when reviewing previous
> >versions of the driver if disabling the chip does anything at all then
> >why don't you need to reenable the chip later?
> OK. I will remove chip disable code in case if _STANDBY and _OFF modes.
So the chip disable does nothing? There's nothing wrong with disabling
the chip when it goes to idle, it's just that one would expect that
something ought to then reenable it when the device is needed again.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-02-03 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 14:30 [PATCH ] ASoC: Add support for TI LM49453 Audio codec Reddy, MR Swami
2012-02-02 23:14 ` Mark Brown
2012-02-03 12:19 ` Reddy, MR Swami
2012-02-03 13:25 ` Mark Brown
2012-02-03 13:33 ` M R Swami Reddy
2012-02-03 13:55 ` Mark Brown [this message]
2012-02-03 14:44 ` M R Swami Reddy
2012-02-03 14:54 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-01-31 11:59 [PATCH] " Reddy, MR Swami
2012-01-31 20:12 ` Mark Brown
[not found] <290463D19D2E064191F1F96ECA480A89434AAB3793@EXMAIL02.scwf.nsc.com>
2012-01-27 14:35 ` Mark Brown
[not found] <290463D19D2E064191F1F96ECA480A89434A67486B@EXMAIL02.scwf.nsc.com>
2012-01-03 21:17 ` Mark Brown
[not found] ` <290463D19D2E064191F1F96ECA480A89434A7595BC@EXMAIL02.scwf.nsc.com>
2012-01-05 6:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203135544.GP3151@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=MR.Swami.Reddy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).