From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@ti.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: core - Add support for DAI and machine kcontrols.
Date: Fri, 3 Feb 2012 20:46:40 +0000 [thread overview]
Message-ID: <20120203204640.GD23505@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1328290989-14399-1-git-send-email-lrg@ti.com>
On Fri, Feb 03, 2012 at 05:43:09PM +0000, Liam Girdwood wrote:
> 1) Use snd_soc_add_card_controls() where no direct codec control is required.
> 2) Use snd_soc_add_codec_controls() where there is direct codec control.
> In the case of 1) above we also update the machine drivers to get the correct
> component data pointers from the kcontrol (rather than getting the machine pointer
> via the codec pointer).
Hrm, I can't apply this right now as I don't have an appropriate system
to hand but what are the cases where there is CODEC control? This
sounds suspicous, perhaps we need some of the drivers enhancing (though
no reason to block this patch).
next prev parent reply other threads:[~2012-02-03 20:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 17:43 [PATCH] ASoC: core - Add support for DAI and machine kcontrols Liam Girdwood
2012-02-03 20:46 ` Mark Brown [this message]
2012-02-06 10:37 ` Liam Girdwood
2012-02-06 11:09 ` Mark Brown
2012-02-06 12:25 ` Liam Girdwood
2012-02-06 13:27 ` Mark Brown
2012-02-06 14:16 ` Liam Girdwood
2012-02-06 14:26 ` Mark Brown
2012-02-06 15:11 ` Vinod Koul
2012-02-06 15:17 ` Mark Brown
2012-02-06 18:09 ` Vinod Koul
2012-02-06 18:19 ` Mark Brown
2012-02-04 12:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203204640.GD23505@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).