From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 18/19] ASoC: fsi: fixup fsi_pointer() calculation method
Date: Wed, 8 Feb 2012 11:50:24 +0000 [thread overview]
Message-ID: <20120208115024.GH3120@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <87obtayynm.wl%kuninori.morimoto.gx@renesas.com>
[-- Attachment #1.1: Type: text/plain, Size: 905 bytes --]
On Tue, Feb 07, 2012 at 04:08:52PM -0800, Kuninori Morimoto wrote:
> > I suspect it's worth fixing in 3.3 then, there's often issues where
> > userspace applications don't work that don't get reported well or at
> > all, often these are due to issues in the pointer implementations.
> > People end up coming up with configurations that work around them and
> > never think that there might be a driver issue.
> I'm not good at detail of user side applications,
> but aplay was working correctly on old/PIO FSI.
> So, I didn't notice it.
aplay is (un)fortunately pretty forgiving here - PulseAudio is the most
difficult test, though some other applications do run into issues too.
Anyway, can you please generate a version of this for 3.3 (or confirm if
the current patch is OK for there) so we can integrate the change there?
The change itself seems good, it's just that it'd be better done as a
fix.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-02-08 11:50 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 8:48 ASoC: fsi: Add FSI DMAEngine support Kuninori Morimoto
2012-02-03 8:50 ` [PATCH 01/19] ASoC: fsi: reduce runtime calculation by using pre-setting Kuninori Morimoto
2012-02-03 8:50 ` [PATCH 02/19] ASoC: fsi: tidyup: fsi_stream_xx() functions were gathered Kuninori Morimoto
2012-02-03 11:42 ` Mark Brown
2012-02-03 8:50 ` [PATCH 03/19] ASoC: fsi: data push/pop calculation part was divided Kuninori Morimoto
2012-02-03 8:51 ` [PATCH 04/19] ASoC: fsi: rename fsi_dma_soft_xxx() to fsi_pio_xxx() Kuninori Morimoto
2012-02-03 8:51 ` [PATCH 05/19] ASoC: fsi: tidyup: move fsi_fifo_init() onto fsi_hw_startup() Kuninori Morimoto
2012-02-03 8:51 ` [PATCH 06/19] ASoC: fsi: remove unnecessary parameter from fsi_hw_shutdown() Kuninori Morimoto
2012-02-03 8:52 ` [PATCH 07/19] ASoC: fsi: rename fsi_stream_push/pop() to fsi_stream_init/quit() Kuninori Morimoto
2012-02-03 8:52 ` [PATCH 08/19] ASoC: fsi: modify fsi_pio_get_area() parameter and using position Kuninori Morimoto
2012-02-03 8:54 ` [PATCH 09/19] ASoC: fsi: re-define fsi_is_play() and fsi_stream_is_play() Kuninori Morimoto
2012-02-03 11:46 ` Mark Brown
2012-02-03 8:55 ` [PATCH 10/19] ASoC: fsi: use fsi_stream in fsi_get_current_fifo_samples() parameter Kuninori Morimoto
2012-02-03 8:55 ` [PATCH 11/19] ASoC: fsi: add fsi_stream_handler and PIO handler Kuninori Morimoto
2012-02-03 8:56 ` [PATCH 12/19] ASoC: fsi: tidyup: fsi_pio_xxx() are gathered Kuninori Morimoto
2012-02-03 8:56 ` [PATCH 13/19] ASoC: fsi: don't use is_play as a parameter of fsi functions Kuninori Morimoto
2012-02-03 8:57 ` [PATCH 14/19] ASoC: fsi: add .start_stop handler to fsi_stream_handler Kuninori Morimoto
2012-02-03 8:57 ` [PATCH 15/19] ASoC: fsi: fsi_stream_is_working() care substream->runtime Kuninori Morimoto
2012-02-03 8:58 ` [PATCH 16/19] ASoC: fsi: PortA/B information was controlled by sh_fsi_port_info Kuninori Morimoto
2012-02-03 8:59 ` [PATCH 17/19] ASoC: fsi: add .init/.quit handler support Kuninori Morimoto
2012-02-03 8:59 ` [PATCH 18/19] ASoC: fsi: fixup fsi_pointer() calculation method Kuninori Morimoto
2012-02-03 11:55 ` Mark Brown
2012-02-06 0:36 ` Kuninori Morimoto
2012-02-06 16:46 ` Mark Brown
2012-02-07 0:13 ` Kuninori Morimoto
2012-02-07 11:29 ` Mark Brown
2012-02-08 0:08 ` Kuninori Morimoto
2012-02-08 11:50 ` Mark Brown [this message]
2012-02-09 0:57 ` [PATCH 18/19 v2] " Kuninori Morimoto
2012-02-09 10:56 ` Mark Brown
2012-02-03 8:59 ` [PATCH 19/19] ASoC: fsi: Add DMAEngine support Kuninori Morimoto
2012-02-03 13:48 ` Mark Brown
2012-02-03 14:05 ` Lars-Peter Clausen
2012-02-03 14:14 ` Mark Brown
2012-02-04 16:31 ` Vinod Koul
2012-02-04 17:00 ` Lars-Peter Clausen
2012-02-04 18:01 ` Vinod Koul
2012-02-04 18:06 ` Vinod Koul
2012-02-04 18:25 ` Lars-Peter Clausen
2012-02-04 18:40 ` Vinod Koul
2012-02-06 8:47 ` Lars-Peter Clausen
2012-02-06 14:46 ` Vinod Koul
2012-02-06 14:50 ` Lars-Peter Clausen
2012-02-04 17:12 ` Mark Brown
2012-02-20 2:40 ` Mark Brown
2012-02-20 6:58 ` Kuninori Morimoto
2012-02-03 11:56 ` ASoC: fsi: Add FSI " Mark Brown
2012-02-06 0:40 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208115024.GH3120@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).