Re: [PATCH 1/2] ASoC: core - Add direct mapping between DAIs and DAPM

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2340 bytes --]

On Thu, Feb 16, 2012 at 01:35:58PM +0000, Liam Girdwood wrote:
> On Wed, 2012-02-15 at 08:24 -0800, Mark Brown wrote:

> > I was thinking about something close to this myself as part of the
> > CODEC<->CODEC automatic DAPM stuff I keep mentioning.  In order to make
> > that work what I was going to do was instead of mapping the widgets
> > directly onto the DAI was to add a DAPM widget that represented the
> > stream and link the DAI to that, probably created automatically from the
> > DAI definition.  We'd then have the DAIs sitting in the DAPM graph and

> I'm easy enough, but I'm not sure how we could map specific PCM channels
> via the DAPM graph. e.g. we could connect the L and R DAC widgets to the
> DAI widget but how would we associate the L DAC widget with PCM channel
> 0 etc. 

We actually need to do that anyway for the CODEC<->CODEC links, I've got
use cases where there are multiple independant streams going over the
same DAI on different channels (eg, stereo pair on 0 and 1, another
stereo pair on 2 and 3).

I can see two ways of doing this.  One is simply to teach DAPM about
these shiny new things like channel numbers in the same way it knows
about mixers and muxes.  Obviously that's a bit invasive but clearly
it'll do the trick.  The other is to hang this in using the connected
callback on the route, have the callback look at the DAI to see what
channels are active and then report if the link is present or not.  The
infrastructure for that is there in DAPM itself already which is nice.

> To give us a unique channel ID for each PCM channel propagating through
> each widget (since I can map PCM channels atm).

> I did connect the DAIs together in the mach driver via DAPM, but I agree
> it would be nicer connect the DAI widgets together here rather than
> DACs, etc.

> The dynamic PCM patch is also blocking on having some sort of DAI ->
> widget mapping so we would need something upstream soonish.

> I'll take a quick look and see if I can modify this and try and include
> a DAI widget too whilst retaining the channel mapping before you have
> breakfast.

I *think* can get something working quickly that doesn't fill in the
blanks for CODEC-CODEC links, though the conference is looking quite
interesting today.  I'll try to send something later.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]