From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: tiwai@suse.de, Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: soc-core: Show the returned values on error messages
Date: Fri, 17 Feb 2012 13:55:36 -0800 [thread overview]
Message-ID: <20120217215535.GB21717@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1329514838-30933-1-git-send-email-festevam@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]
On Fri, Feb 17, 2012 at 07:40:38PM -0200, Fabio Estevam wrote:
> Showing the returned values on error messages is useful information.
>
> While at it, use pr_err/pr_warn whenever possible.
Applied, thanks. I rather suspect a lot of these should really be devm_
rather than just plain old pr_.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-02-17 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 21:40 [PATCH] ASoC: soc-core: Show the returned values on error messages Fabio Estevam
2012-02-17 21:55 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217215535.GB21717@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).