From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Vinod Koul <vinod.koul@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Ryan Mallon <rmallon@gmail.com>,
alsa-devel@alsa-project.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Wolfram Sang <w.sang@pengutronix.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mika Westerberg <mika.westerberg@iki.fi>,
Shawn Guo <shawn.guo@linaro.org>, Liam Girdwood <lrg@ti.com>
Subject: Re: [RFC 4/7] ASoC: Add dmaengine PCM helper functions
Date: Wed, 22 Feb 2012 15:23:55 +0000 [thread overview]
Message-ID: <20120222152355.GG22562@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120222150455.GO7340@opensource.wolfsonmicro.com>
On Wed, Feb 22, 2012 at 03:04:56PM +0000, Mark Brown wrote:
> Well, if we can't do it with a layer in the dmaengine code then I don't
> see how we could do it in ASoC either, presumably the issues that block
> doing it in the dmaengine core code would also cause issues doing it in
> ASoC?
>
> I'm not saying there's nothing that needs fixing in the dmaengine code,
> and like I say I'm not too worried about carrying things in ASoC if the
> dmaengine code is intractably difficult, but I'm not sure that the
> issues you're rasing aren't orthogonal to the issues with emulating
> cyclic transfers.
Look, I spent a number of weeks working on the SA11x0 DMA engine code
and ALSA side to get something which worked reliably, and a simple
solution doesn't work. I've been looking at the DMA engine code
probably for longer than Vinod has been involved with it. I've been
working on cleaning up all the DMA engine drivers extracting some of the
common bits from them. I'm very familiar with level of crap in the DMA
engine stuff. I know what I'm talking about.
The point that I'm making is that there's more to this than just adding
a layer. If you think that's all that there is, then you haven't properly
understood the SA11x0 audio support patch set that I have, and the
interactions between the individual patches. That's not surprising
because I haven't posted the patches yet, and I haven't explained them
either.
And since I'm spending today working on x86 kernel instability (thanks to
Linux for taking out my laptop last night) I've little time to spend
discussing the fine points of this, let alone any other ARM stuff.
next prev parent reply other threads:[~2012-02-22 15:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 9:49 [RFC 0/7] ASoC: Introduce dmaengine pcm helper functions Lars-Peter Clausen
2012-02-22 9:49 ` [RFC 1/7] ASoC: imx-ssi: Set dma data early Lars-Peter Clausen
2012-02-22 13:22 ` Mark Brown
2012-02-22 9:49 ` [RFC 2/7] ASoC: imx-pcm: Request DMA channel early Lars-Peter Clausen
2012-02-22 13:22 ` Mark Brown
2012-02-22 9:49 ` [RFC 3/7] ASoC: mxs-pcm: " Lars-Peter Clausen
2012-02-22 13:22 ` Mark Brown
2012-02-22 9:49 ` [RFC 4/7] ASoC: Add dmaengine PCM helper functions Lars-Peter Clausen
2012-02-22 10:01 ` Russell King - ARM Linux
2012-02-22 12:52 ` Lars-Peter Clausen
2012-02-22 13:00 ` Mark Brown
2012-02-22 13:21 ` Mark Brown
2012-02-22 13:30 ` Vinod Koul
2012-02-22 13:30 ` Mark Brown
2012-02-22 13:32 ` Russell King - ARM Linux
2012-02-22 13:39 ` Mark Brown
2012-02-22 14:22 ` Russell King - ARM Linux
2012-02-22 15:04 ` Mark Brown
2012-02-22 15:23 ` Russell King - ARM Linux [this message]
2012-02-22 15:39 ` Mark Brown
2012-02-23 6:57 ` Vinod Koul
2012-03-02 13:59 ` Mark Brown
2012-03-05 12:30 ` Lars-Peter Clausen
2012-03-05 12:41 ` Mark Brown
2012-03-07 0:38 ` Kuninori Morimoto
2012-03-07 11:42 ` Mark Brown
2012-02-22 9:49 ` [RFC 5/7] ASoC: imx-pcm-dma: Use " Lars-Peter Clausen
2012-02-22 9:49 ` [RFC 6/7] ASoC: mxs-pcm: " Lars-Peter Clausen
2012-02-22 9:49 ` [RFC 7/7] ASoC: ep93xx-pcm: " Lars-Peter Clausen
2012-02-27 8:19 ` Mika Westerberg
2012-02-27 8:51 ` Lars-Peter Clausen
2012-02-27 19:01 ` Mika Westerberg
2012-02-28 8:47 ` Lars-Peter Clausen
2012-02-28 12:52 ` Mark Brown
2012-02-28 14:17 ` Lars-Peter Clausen
2012-02-28 14:30 ` Mark Brown
2012-02-28 19:23 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222152355.GG22562@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lrg@ti.com \
--cc=mika.westerberg@iki.fi \
--cc=rmallon@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@linux.intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).