From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: javier Martin <javier.martin@vista-silicon.com>
Cc: alsa-devel@alsa-project.org, Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [Q] ASoC: What's the real meaning of SND_SOC_DAIFMT_NB_NF?
Date: Thu, 23 Feb 2012 16:14:47 +0000 [thread overview]
Message-ID: <20120223161446.GA7245@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACKLOr23+DPp=XZ=RJEPgKYyvw3UOxkWR8xtzYG9Y9NWcicJSg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1004 bytes --]
On Thu, Feb 23, 2012 at 04:58:09PM +0100, javier Martin wrote:
> So, let's see if I understood properly. If I want to configure the
> i.MX SSI into standard, I2S format I should do:
> dai_format = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF;
> snd_soc_dai_set_fmt(cpu_dai, dai_format);
Yes.
> While initially TFSI bit is set because of I2S flag, it is then
> cleared because of the NB_NF.
> Does this mean this is a bug then? If it is, I would gladly fix it but
I've no idea what any of the register settings mean here...
> there is at least one platform relying on this misleading behavior
> that I can't test:
> http://lxr.linux.no/#linux+v3.2.7/sound/soc/imx/wm1133-ev1.c#L81
That was correct at the time it was written, though the code has changed
since then and I don't know when it was last retested. Of course
depending on the signal it may interoperate well even if the setup isn't
actually correct. I'd just fix the driver and if it works for yours
it's probably OK for that board too.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-02-23 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 12:40 [Q] ASoC: What's the real meaning of SND_SOC_DAIFMT_NB_NF? javier Martin
2012-02-23 15:19 ` Mark Brown
2012-02-23 15:58 ` javier Martin
2012-02-23 16:14 ` Mark Brown [this message]
2012-02-24 7:53 ` javier Martin
2012-02-24 8:34 ` Peter Ujfalusi
2012-02-24 11:05 ` javier Martin
2012-02-24 11:53 ` Mark Brown
2012-02-24 14:09 ` Peter Ujfalusi
2012-02-24 11:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223161446.GA7245@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=javier.martin@vista-silicon.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).