From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Grazvydas Ignotas <notasas@gmail.com>
Subject: Re: [PATCH] ASoC: omap-mcbsp: When closing the port select PRCM source for CLKS signal
Date: Mon, 5 Mar 2012 11:58:08 +0000 [thread overview]
Message-ID: <20120305115808.GD3224@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1330940332-16188-1-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 641 bytes --]
On Mon, Mar 05, 2012 at 11:38:52AM +0200, Peter Ujfalusi wrote:
> If external source for the CLKS signal selection kept after the port is no
> longer in use the system might refuse to go suspend.
> There is also a chance that the external clock is not running when next
> time the McBSP port is started which can result errors when we try to
> access McBSP registers.
> Reset the CLKS source back to PRCM source unconditionally.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
though it'd be better if the driver could remember and restore the
setting when the device becomes active again so that machine drivers
don't need to.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-03-05 11:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 9:38 [PATCH] ASoC: omap-mcbsp: When closing the port select PRCM source for CLKS signal Peter Ujfalusi
2012-03-05 11:58 ` Mark Brown [this message]
2012-03-05 12:33 ` Peter Ujfalusi
2012-03-05 12:51 ` Grazvydas Ignotas
2012-03-05 13:02 ` Peter Ujfalusi
2012-03-06 12:54 ` Peter Ujfalusi
2012-03-06 14:44 ` Liam Girdwood
2012-03-08 14:00 ` Grazvydas Ignotas
2012-03-08 14:30 ` Ujfalusi, Peter
2012-03-08 22:48 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305115808.GD3224@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lrg@ti.com \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).