From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@ti.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: DAPM - Make sure DAPM widget IO ops hold the component mutex.
Date: Wed, 7 Mar 2012 10:54:27 +0000 [thread overview]
Message-ID: <20120307105426.GA3107@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331115061.3829.11.camel@odin>
[-- Attachment #1.1: Type: text/plain, Size: 749 bytes --]
On Wed, Mar 07, 2012 at 10:11:01AM +0000, Liam Girdwood wrote:
> On Tue, 2012-03-06 at 20:03 +0000, Mark Brown wrote:
> > Actually for CODECs we don't need to hold the CODEC mutex for I/O if
> > we've pushed the cache down into regmap - regmap does all the locking
> > for us. I'll send a followup patch.
> I know, but this patch did check for regmap usage in
> soc_widget_update_bits_locked(). With your fix we are doing the regmap
> test twice.
Yes, we are but it's a simple comparison with integer so not the end of
the world. I'd much rather have the check in the locking code so it's
clear what's expected instead of split between one of the call sites and
the locking function where it might easily get missed if someone adds a
new user.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-03-07 10:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 18:16 [PATCH 1/2] ASoC: core - Add platform component mutex Liam Girdwood
2012-03-06 18:16 ` [PATCH 2/2] ASoC: DAPM - Make sure DAPM widget IO ops hold the " Liam Girdwood
2012-03-06 20:03 ` Mark Brown
2012-03-07 10:11 ` Liam Girdwood
2012-03-07 10:54 ` Mark Brown [this message]
2012-03-07 11:13 ` Liam Girdwood
2012-03-07 20:00 ` Mark Brown
2012-03-09 17:26 ` Tabi Timur-B04825
2012-03-09 18:14 ` Liam Girdwood
2012-03-09 19:11 ` Timur Tabi
2012-03-11 12:55 ` Mark Brown
2012-03-11 13:58 ` Tabi Timur-B04825
2012-03-12 9:12 ` Shawn Guo
2012-03-12 9:27 ` Liam Girdwood
2012-03-12 10:42 ` Mark Brown
2012-03-06 20:09 ` [PATCH 1/2] ASoC: core - Add platform " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307105426.GA3107@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).