From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: alsa-devel@alsa-project.org, qi.wang@intel.com,
Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, yong.y.wang@intel.com,
kok.howg.ewe@intel.com, Liam Girdwood <lrg@ti.com>,
joel.clark@intel.com
Subject: Re: [PATCH v3] sound/soc/lapis: add platform driver for ML7213
Date: Wed, 7 Mar 2012 11:46:32 +0000 [thread overview]
Message-ID: <20120307114631.GE3107@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CANKRQngg+8LJvb-+Byv6XPqqWFyCU1U+-hppuxo_=CM1qLUF_Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1155 bytes --]
On Wed, Mar 07, 2012 at 10:30:05AM +0900, Tomoya MORINAGA wrote:
> On Tue, Mar 6, 2012 at 8:52 PM, Mark Brown
> >> if these platform devices aren't used, device detection doesn't work correctly.
> >> So, I added these.
> > You've not actually mentioned the problem you were seeing...
> I saw mapping problem between machine driver and platform driver.
> e.g. cpu_dai_name "ml7213ioh"
You've still not explained the problem you're seeing but this sounds
like something that should work. Please address the
> > Apart from anything else you've got the interrupt requested as
> > IRQF_SHARED so the interrupt could get called at any time. It's also
> > not clear that you've got the hardware in a known good state.
> Do you mean request_irq should move to somewhere, like open() or
> hw_params() or ... ?
You need to do enough hardware and software initialisation prior to
requesting the interrupt to ensure that if an interrupt does happen it
won't cause any ill effects. Checks in the interrupt handler to make
sure things like the ALSA layer stuff have been set up can also be used
to make the interrupt handler safer.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-03-07 11:46 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 5:46 [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124 Tomoya MORINAGA
2012-02-23 5:46 ` [PATCH v3] sound/soc/lapis: add platform driver for ML7213 Tomoya MORINAGA
2012-03-02 16:39 ` Mark Brown
2012-03-06 5:48 ` Tomoya MORINAGA
2012-03-06 11:52 ` Mark Brown
2012-03-07 1:30 ` Tomoya MORINAGA
2012-03-07 11:46 ` Mark Brown [this message]
2012-03-08 2:06 ` Tomoya MORINAGA
2012-03-08 11:05 ` Mark Brown
2012-03-09 6:26 ` Tomoya MORINAGA
2012-03-09 6:39 ` [PATCH v4] " Tomoya MORINAGA
2012-03-19 12:00 ` [PATCH v5] " Tomoya MORINAGA
2012-03-21 16:09 ` Mark Brown
2012-03-22 0:12 ` Tomoya MORINAGA
2012-03-26 15:40 ` Mark Brown
2012-05-23 4:17 ` Tomoya MORINAGA
2012-05-23 9:41 ` Mark Brown
2012-05-23 23:46 ` Tomoya MORINAGA
2012-05-24 10:07 ` Mark Brown
2012-05-25 9:30 ` Tomoya MORINAGA
2012-05-25 10:20 ` Vinod Koul
2012-05-27 22:19 ` Mark Brown
2012-05-30 10:50 ` Tomoya MORINAGA
2012-05-30 12:14 ` [alsa-devel] " Mark Brown
2012-05-31 5:38 ` Tomoya MORINAGA
2012-05-31 10:45 ` Mark Brown
2012-06-01 8:13 ` Tomoya MORINAGA
2012-06-01 8:30 ` Mark Brown
2012-06-11 7:05 ` Tomoya MORINAGA
2012-06-11 8:54 ` Mark Brown
2012-06-13 10:41 ` Tomoya MORINAGA
2012-06-13 12:11 ` Mark Brown
2012-05-28 5:35 ` Tomoya MORINAGA
2012-02-23 5:46 ` [PATCH v5] sound/soc/lapis: add machine driver for ML7213 Carrier Board Tomoya MORINAGA
2012-03-02 13:05 ` Mark Brown
2012-03-06 5:49 ` Tomoya MORINAGA
2012-03-06 11:54 ` Mark Brown
2012-03-07 1:57 ` Tomoya MORINAGA
2012-03-09 6:38 ` [PATCH v6] " Tomoya MORINAGA
2012-03-14 14:45 ` Mark Brown
2012-03-15 4:50 ` Tomoya MORINAGA
2012-03-15 10:50 ` Mark Brown
2012-03-16 4:07 ` Tomoya MORINAGA
2012-03-16 19:06 ` Mark Brown
2012-03-18 23:45 ` Tomoya MORINAGA
2012-03-19 12:02 ` [PATCH v7] " Tomoya MORINAGA
2012-03-19 19:21 ` Mark Brown
2012-03-21 0:51 ` Tomoya MORINAGA
2012-02-29 23:51 ` [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124 Mark Brown
2012-03-02 8:16 ` Tomoya MORINAGA
2012-03-02 12:58 ` Mark Brown
2012-03-06 3:03 ` Tomoya MORINAGA
2012-03-06 10:00 ` Mark Brown
2012-03-06 10:49 ` Tomoya MORINAGA
2012-03-06 12:12 ` Mark Brown
2012-03-07 2:16 ` Tomoya MORINAGA
2012-03-07 11:48 ` Mark Brown
2012-03-08 2:24 ` Tomoya MORINAGA
2012-03-08 11:47 ` Mark Brown
2012-03-09 6:37 ` [PATCH v7] " Tomoya MORINAGA
2012-03-14 14:39 ` Mark Brown
2012-03-15 4:51 ` Tomoya MORINAGA
2012-03-14 17:40 ` [alsa-devel] [PATCH v6] " Lars-Peter Clausen
2012-03-14 17:45 ` Mark Brown
2012-03-15 6:29 ` Tomoya MORINAGA
2012-03-16 9:55 ` Tomoya MORINAGA
2012-03-17 21:52 ` [alsa-devel] " Mark Brown
2012-03-19 11:59 ` [PATCH v8] " Tomoya MORINAGA
2012-03-19 19:07 ` Mark Brown
2012-03-21 0:57 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307114631.GE3107@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=tomoya.rohm@gmail.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).