alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: imx: imx-audmux: Fix section mismatch
@ 2012-03-07 18:18 Fabio Estevam
  0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2012-03-07 18:18 UTC (permalink / raw)
  To: alsa-devel; +Cc: Fabio Estevam, s.hauer, richard.zhao

Fix the following section mismatch warning:

WARNING: vmlinux.o(.data+0x35be8): Section mismatch in reference from the variable imx_audmux_driver to the function .init.text:imx_audmux_probe()
The variable imx_audmux_driver references
the function __init imx_audmux_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 sound/soc/imx/imx-audmux.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/imx/imx-audmux.c b/sound/soc/imx/imx-audmux.c
index ef425ad..601df80 100644
--- a/sound/soc/imx/imx-audmux.c
+++ b/sound/soc/imx/imx-audmux.c
@@ -167,7 +167,7 @@ static void __init audmux_debugfs_init(void)
 	}
 }
 
-static void __exit audmux_debugfs_remove(void)
+static void __devexit audmux_debugfs_remove(void)
 {
 	debugfs_remove_recursive(audmux_debugfs_root);
 }
@@ -249,7 +249,7 @@ int imx_audmux_v2_configure_port(unsigned int port, unsigned int ptcr,
 }
 EXPORT_SYMBOL_GPL(imx_audmux_v2_configure_port);
 
-static int __init imx_audmux_probe(struct platform_device *pdev)
+static int __devinit imx_audmux_probe(struct platform_device *pdev)
 {
 	struct resource *res;
 	const struct of_device_id *of_id =
@@ -276,7 +276,7 @@ static int __init imx_audmux_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int __exit imx_audmux_remove(struct platform_device *pdev)
+static int __devexit imx_audmux_remove(struct platform_device *pdev)
 {
 	if (audmux_type == IMX31_AUDMUX)
 		audmux_debugfs_remove();
@@ -287,7 +287,7 @@ static int __exit imx_audmux_remove(struct platform_device *pdev)
 
 static struct platform_driver imx_audmux_driver = {
 	.probe		= imx_audmux_probe,
-	.remove		= __exit_p(imx_audmux_remove),
+	.remove		= __devexit_p(imx_audmux_remove),
 	.id_table	= imx_audmux_ids,
 	.driver	= {
 		.name	= DRIVER_NAME,
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ASoC: imx: imx-audmux: Fix section mismatch
@ 2012-03-07 18:19 Fabio Estevam
  2012-03-07 19:32 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2012-03-07 18:19 UTC (permalink / raw)
  To: alsa-devel; +Cc: Fabio Estevam, s.hauer, broonie, richard.zhao

Fix the following section mismatch warning:

WARNING: vmlinux.o(.data+0x35be8): Section mismatch in reference from the variable imx_audmux_driver to the function .init.text:imx_audmux_probe()
The variable imx_audmux_driver references
the function __init imx_audmux_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 sound/soc/imx/imx-audmux.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/imx/imx-audmux.c b/sound/soc/imx/imx-audmux.c
index ef425ad..601df80 100644
--- a/sound/soc/imx/imx-audmux.c
+++ b/sound/soc/imx/imx-audmux.c
@@ -167,7 +167,7 @@ static void __init audmux_debugfs_init(void)
 	}
 }
 
-static void __exit audmux_debugfs_remove(void)
+static void __devexit audmux_debugfs_remove(void)
 {
 	debugfs_remove_recursive(audmux_debugfs_root);
 }
@@ -249,7 +249,7 @@ int imx_audmux_v2_configure_port(unsigned int port, unsigned int ptcr,
 }
 EXPORT_SYMBOL_GPL(imx_audmux_v2_configure_port);
 
-static int __init imx_audmux_probe(struct platform_device *pdev)
+static int __devinit imx_audmux_probe(struct platform_device *pdev)
 {
 	struct resource *res;
 	const struct of_device_id *of_id =
@@ -276,7 +276,7 @@ static int __init imx_audmux_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int __exit imx_audmux_remove(struct platform_device *pdev)
+static int __devexit imx_audmux_remove(struct platform_device *pdev)
 {
 	if (audmux_type == IMX31_AUDMUX)
 		audmux_debugfs_remove();
@@ -287,7 +287,7 @@ static int __exit imx_audmux_remove(struct platform_device *pdev)
 
 static struct platform_driver imx_audmux_driver = {
 	.probe		= imx_audmux_probe,
-	.remove		= __exit_p(imx_audmux_remove),
+	.remove		= __devexit_p(imx_audmux_remove),
 	.id_table	= imx_audmux_ids,
 	.driver	= {
 		.name	= DRIVER_NAME,
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: imx: imx-audmux: Fix section mismatch
  2012-03-07 18:19 [PATCH] ASoC: imx: imx-audmux: Fix section mismatch Fabio Estevam
@ 2012-03-07 19:32 ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-03-07 19:32 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: alsa-devel, s.hauer, richard.zhao


[-- Attachment #1.1: Type: text/plain, Size: 127 bytes --]

On Wed, Mar 07, 2012 at 03:19:57PM -0300, Fabio Estevam wrote:
> Fix the following section mismatch warning:

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-07 19:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 18:19 [PATCH] ASoC: imx: imx-audmux: Fix section mismatch Fabio Estevam
2012-03-07 19:32 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2012-03-07 18:18 Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).