From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v6] sound/soc/lapis: add machine driver for ML7213 Carrier Board Date: Wed, 14 Mar 2012 14:45:24 +0000 Message-ID: <20120314144524.GT3133@opensource.wolfsonmicro.com> References: <1331275091-31700-1-git-send-email-tomoya.rohm@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8361269685937376683==" Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 68CCB104556 for ; Wed, 14 Mar 2012 15:45:26 +0100 (CET) In-Reply-To: <1331275091-31700-1-git-send-email-tomoya.rohm@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tomoya MORINAGA Cc: alsa-devel@alsa-project.org, qi.wang@intel.com, Takashi Iwai , linux-kernel@vger.kernel.org, yong.y.wang@intel.com, kok.howg.ewe@intel.com, Liam Girdwood , joel.clark@intel.com List-Id: alsa-devel@alsa-project.org --===============8361269685937376683== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9hshNW4m6zn79FF/" Content-Disposition: inline --9hshNW4m6zn79FF/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 09, 2012 at 03:38:11PM +0900, Tomoya MORINAGA wrote: > + /* set codec DAI configuration */ > + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS); > + if (ret < 0) > + return ret; > + > + /* set cpu DAI configuration */ > + ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBM_CFM); This looks very broken, you're setting the two ends of the link to different configurations. If this is needed it should be documented why. Also, this should be set in the dai_link structure as data rather than set each time. --9hshNW4m6zn79FF/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPYK6XAAoJEBus8iNuMP3dUegP/3c584uB/C3MMpEFcdB/Oy5g xl77tzaYuGQTXH5yLVa9MCntKG+pmO1gL1AG1VHb+jiFdhNeuBv8omIyWLFkkCV0 rTW74+EQ2e0+vcGEZUOT4Y8sNxRZHrFFLJQSWNaAZflt9I9ydm6HliZuBpvt6hEW wJwJbgU0BOLX+7B8MGbAEcGbEdpyr+NIy2zAqdwiIdmZf5RhxFVJCKJimwbCeePC c17Al0KV2aCqrM35Xs6pz10aLikKGi0W837JY6mpOn3dqR6ssTrxLDJ1wm84E11e dtYzP5FM6NQVID0WgJY2GZ1Um5T1YmkAHEgTSjLDckPBU+EyNBqLUA7F4OplBcfV IN2Jn12kE5KtoIBkc2hfdPOI9KQV5cnSg4lt2iUUY8GUKcF9PVlES/0WkAzrBKJO xHfzidH1Gmgz4rIqAxiqe8Z/e2lvmJVaawfxyOwceEMaU74dkhq5BWTcTk8gFVRv rZnUJq+HUq/5gooh1IQsVWHxkhtcYVFuVCy3M0pqjRuGbqBPnaD6NT8hR/XASLVp +3eU+Mb/e8evCk4i0Ap6SEtx2q9F3ir2jA/TbeHzLU4N8ws6QReQyZ0iRSb70uze wyztsD5ayIf2MZBUdmFAG48kCmfu+W8juQYXiaBRqrY+chz/mfrR0FsIGQ8d21b7 q22nO63zEAnO5x6PSn8R =z388 -----END PGP SIGNATURE----- --9hshNW4m6zn79FF/-- --===============8361269685937376683== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============8361269685937376683==--