From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Rajeev kumar <rajeev-dlh.kumar@st.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
spear-devel <spear-devel@list.st.com>
Subject: Re: [PATCH 2/8] sound:asoc: Add support for synopsys i2s controller as per ASoC framework.
Date: Mon, 26 Mar 2012 12:10:55 +0100 [thread overview]
Message-ID: <20120326111055.GM3098@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F7030DA.2090009@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 805 bytes --]
On Mon, Mar 26, 2012 at 02:33:22PM +0530, Rajeev kumar wrote:
> On 3/20/2012 9:14 PM, Mark Brown wrote:
> >On Tue, Mar 20, 2012 at 05:03:46PM +0530, Rajeev Kumar wrote:
> >>+ if (dev->i2s_clk_cfg(config)) {
> >>+ dev_err(dev->dev, "runtime audio clk config fail\n");
> >>+ if (cpu_dai->driver->ops->trigger) {
> >>+ int ret =
> >>+ cpu_dai->driver->ops->trigger(substream,
> >>+ SNDRV_PCM_TRIGGER_STOP,
> >>+ cpu_dai);
> >>+ if (ret< 0) {
> >>+ dev_err(dev->dev,
> >>+ "trigger stop fail\n");
> >>+ return ret;
> >>+ }
> >>+ }
> >No, return an error if you encounter an error!
> You need not to stop controller in case clock fail ?
Let the upper layers worry about that. Don't randomly change the state
of the controller without them knowing about it.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-03-26 11:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 11:33 [PATCH 0/8] Add ASoC drivers for SPEAr platform Rajeev Kumar
2012-03-20 11:33 ` [PATCH 1/8] sound:asoc: Add support for STA529 Audio Codec Rajeev Kumar
2012-03-20 15:25 ` Mark Brown
2012-03-23 3:42 ` Rajeev kumar
2012-03-23 9:07 ` Lars-Peter Clausen
2012-03-23 9:20 ` Rajeev kumar
2012-03-20 17:57 ` Lars-Peter Clausen
2012-03-23 4:00 ` Rajeev kumar
2012-03-23 8:51 ` Lars-Peter Clausen
2012-03-23 9:15 ` Rajeev kumar
2012-03-20 11:33 ` [PATCH 2/8] sound:asoc: Add support for synopsys i2s controller as per ASoC framework Rajeev Kumar
2012-03-20 15:44 ` Mark Brown
2012-03-26 9:03 ` Rajeev kumar
2012-03-26 11:10 ` Mark Brown [this message]
2012-03-27 3:51 ` Rajeev kumar
2012-03-20 11:33 ` [PATCH 3/8] sound:asoc: Add support for SPEAr ASoC pcm layer Rajeev Kumar
2012-03-20 15:50 ` Mark Brown
2012-03-20 11:33 ` [PATCH 4/8] sound:asoc:spdif_in: Add spdif IN support Rajeev Kumar
2012-03-20 15:55 ` Mark Brown
2012-03-27 9:25 ` Rajeev kumar
2012-03-20 11:33 ` [PATCH 5/8] sound:asoc:spdif_out: Add spdif out support Rajeev Kumar
2012-03-20 11:33 ` [PATCH 6/8] sound:asoc: Add support for SPEAr ASoC machine driver Rajeev Kumar
2012-03-20 16:00 ` Mark Brown
2012-03-20 11:33 ` [PATCH 7/8] sound:asoc: Add Kconfig and Makefile to support SPEAr audio driver Rajeev Kumar
2012-03-20 11:33 ` [PATCH 8/8] sound:asoc: Update Kconfig and Makefile(sound/soc/) to support SPEAr audio Rajeev Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326111055.GM3098@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=rajeev-dlh.kumar@st.com \
--cc=spear-devel@list.st.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).