From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Zeng Zhaoming <zengzm.kernel@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: sgtl5000: Convert mic bias to a supply widget
Date: Thu, 29 Mar 2012 11:56:46 +0100 [thread overview]
Message-ID: <20120329105646.GB3668@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120329052410.GA19506@S2101-09.ap.freescale.net>
[-- Attachment #1.1: Type: text/plain, Size: 1009 bytes --]
On Thu, Mar 29, 2012 at 01:24:13PM +0800, Shawn Guo wrote:
> On Wed, Mar 28, 2012 at 08:53:45PM +0100, Mark Brown wrote:
> > - SND_SOC_DAPM_MICBIAS_E("Mic Bias", SGTL5000_CHIP_MIC_CTRL, 8, 0,
> > - mic_bias_event,
> > - SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),
> > + SND_SOC_DAPM_SUPPLY("Mic Bias", SGTL5000_CHIP_MIC_CTRL, 8, 0,
> > + mic_bias_event,
> > + SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),
> It breaks my capture testing.
Well, any capture testing that uses mic bias shouldn't work in mainline
anyway - there's no hookup in the machine driver.
> I'm not sure these two macros are equivalent, since they have different
> .id assignment. To quickly confirm the problem, I have the capture
> back to work with the following change.
You'll need to change the hookup in your machine to adapt to the change
of widget type - see the previous conversions that have been done in git
history for examples. No device tree bindings should be using old style
mic bias hookups.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-03-29 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 19:53 [PATCH 1/2] ASoC: sgtl5000: Convert mic bias to a supply widget Mark Brown
2012-03-28 19:53 ` [PATCH 2/2] ASoC: dapm: Remove SND_SOC_DAPM_MICBIAS_E() Mark Brown
2012-03-28 23:02 ` WM8994 playback delay Sangbeom Kim
2012-03-29 10:50 ` Mark Brown
2012-03-29 3:40 ` [PATCH 1/2] ASoC: sgtl5000: Convert mic bias to a supply widget Dong Aisheng
2012-03-29 5:24 ` Shawn Guo
2012-03-29 10:56 ` Mark Brown [this message]
2012-03-29 14:11 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329105646.GB3668@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=lrg@ti.com \
--cc=shawn.guo@linaro.org \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).