From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: alsa-devel@alsa-project.org, Zeng Zhaoming <zengzm.kernel@gmail.com>
Subject: Re: [PATCH] ASoC: sgtl5000: Enable VAG when DAC/ADC up
Date: Thu, 29 Mar 2012 15:10:20 +0100 [thread overview]
Message-ID: <20120329141019.GQ3668@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120329140420.GD19506@S2101-09.ap.freescale.net>
[-- Attachment #1.1: Type: text/plain, Size: 907 bytes --]
On Thu, Mar 29, 2012 at 10:04:23PM +0800, Shawn Guo wrote:
> On Thu, Mar 29, 2012 at 11:58:32AM +0100, Mark Brown wrote:
> > No, the bias should be a supply for the microphone - ensuring that this
> > happens is the whole point of the patch I sent the other day.
> The "MIC" above is confusing. I guess the following that I have in
> machine driver might be a little clearer.
> {"Mic Bias", NULL, "Mic Jack"},
> {"MIC_IN", NULL, "Mic Bias"},
This should be something like:
{ "Mic Jack", NULL, "Mic Bias" },
{ "MIC_IN", NULL, "Mic Bias" },
(with the conversion of Mic Bias to a supply widget) which has the bonus
of being a whole lot easier to understand.
> And I need to present it in device tree though.
Use the generic stuff that Stephen put into the core for reading machine
driver routing maps out of the device tree (unless there's some problem
with it, but it should work).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-03-29 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 5:51 [PATCH] ASoC: sgtl5000: Enable VAG when DAC/ADC up Shawn Guo
[not found] ` <20120329071700.GA18127@zzm-ubuntu>
2012-03-29 10:58 ` Mark Brown
2012-03-29 14:04 ` Shawn Guo
2012-03-29 14:10 ` Mark Brown [this message]
2012-03-29 14:19 ` Shawn Guo
2012-04-25 2:08 ` Richard Zhao
2012-04-25 8:11 ` Mark Brown
2012-03-29 11:16 ` Mark Brown
2012-03-29 11:24 ` Dong Aisheng-B29396
[not found] ` <20120329120933.GA27740@zzm-ubuntu>
2012-03-29 12:11 ` Mark Brown
2012-03-29 13:54 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329141019.GQ3668@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=shawn.guo@linaro.org \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).