Re: [PATCH 14/17] ASoC: tegra: add tegra30-ahub driver

[Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On Fri, Mar 30, 2012 at 05:07:29PM -0600, Stephen Warren wrote:

> +int tegra30_ahub_is_probed(void)
> +{
> +	return probed;
> +}
> +EXPORT_SYMBOL(tegra30_ahub_is_probed);

This looks like a fairly clear sign that this should be a CODEC driver,
or possibly the DMA driver - if nothing else even if you didn't change
anything else about the implementation it'd ensure that you didn't need
to open code this probe checking.

All your EXPORT_SYMBOLs should really be EXPORT_SYMBOL_GPL as you're
using the ASoC APIs.

> +/*
> + * clk_apbif isn't required for a theoretical I2S<->I2S configuration where
> + * no PCM data is read from or sent to memory. However, that's an unlikely
> + * use-case, and not something the rest of the driver supports right now, so
> + * we'll just treat the two clocks as one for now.

I rather suspect you'll find your system architects view that as a
resonable use case for things like voice calls where the audio for the
call would go from the baseband to the CODEC or bluetooth without going
into main memory.  Of course many CODECs can take this path directly
allowing the CPU to be powered off so...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]