Re: [PATCH 15/17] ASoC: tegra: add tegra30-i2s driver

[Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

On Fri, Mar 30, 2012 at 05:07:30PM -0600, Stephen Warren wrote:

> +#ifdef CONFIG_DEBUG_FS
> +static int tegra30_i2s_show(struct seq_file *s, void *unused)
> +{

Abstraction please - this is open coded in several of your drivers.

> +	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> +		ret = tegra30_ahub_allocate_tx_fifo(&i2s->txcif,
> +					&i2s->playback_dma_data.addr,
> +					&i2s->playback_dma_data.req_sel);
> +		i2s->playback_dma_data.wrap = 4;
> +		i2s->playback_dma_data.width = 32;
> +		tegra30_ahub_set_rx_cif_source(
> +				TEGRA30_AHUB_RXCIF_I2S0_RX0 + i2s->cif_id,
> +				i2s->txcif);

So.  This is all fairly straightforward, simple and non-invasive for
CPU<->I2S streams but obviously it's locking out any loopbacks within
the AHUB which is a bit sad.

Looking at this it seems like all that's required is to propagate stream
events back up the chain and do the routing, there doesn't seem to be
much other interaction between the AHUB and the interfaces?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]