Re: [PATCH 12/17] ASoC: tegra: utils: add support for Tegra30 devices

[Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On Sat, Mar 31, 2012 at 07:57:12PM -0600, Stephen Warren wrote:
> On 03/31/2012 02:20 PM, Mark Brown wrote:
> > On Fri, Mar 30, 2012 at 05:07:27PM -0600, Stephen Warren wrote:

> >> -	ret = tegra_asoc_utils_init(&alc5632->util_data, &pdev->dev);
> >> + ret = tegra_asoc_utils_init(&alc5632->util_data, + 
> >> TEGRA_ASOC_UTILS_SOC_TEGRA20, &pdev->dev);

> > Would it not be more sensible to do cpu_is_() calls in the utils 
> > code rather than have the board say?  It'd possibly also end up 
> > looking nicer in the code and may mean the compiler can figure out 
> > not to include cases that can't be taken in the current build.

> We had floated the idea of adding cpu_is_*() (Well, soc_is_*()) macros
> for Tegra in the past, and received the message that was a bad idea;
> things should instead be driven by compatible flag values or similar.

Or look at the binding, or something.  Having the machine drivers need
to translate the bindings into these defines just feels clunky.

> See http://www.spinics.net/lists/linux-tegra/msg02250.html. That said,
> I see many cpu_is_*() calls in arch/arm, so perhaps we should revisit
> this.

Many of those might get some pushback in this day and age.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]