[PATCH] ASoC: core: Initialize err for snd_soc_put_volsw_sx

[PATCH] ASoC: core: Initialize err for snd_soc_put_volsw_sx

[Brian Austin]

sound/soc/soc-core.c: In function ‘snd_soc_put_volsw_sx’:
sound/soc/soc-core.c:2600: warning: ‘err’ may be used uninitialized in this function

Acked-by:Brian Austin <brian.austin@cirrus.com>
---
 sound/soc/soc-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 7b1a4fd..a6922bc 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2586,7 +2586,7 @@ int snd_soc_put_volsw_sx(struct snd_kcontrol *kcontrol,
 	int max = mc->max;
 	int min = mc->min;
 	int mask = (1 << (fls(min + max) - 1)) - 1;
-	int err;
+	int err = 0;
 	unsigned short val, val_mask, val2 = 0;
 
 	val_mask = mask << shift;
-- 
1.7.9.1


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: core: Initialize err for snd_soc_put_volsw_sx

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 328 bytes --]

On Tue, Apr 03, 2012 at 10:42:32AM -0500, Brian Austin wrote:
> sound/soc/soc-core.c: In function ‘snd_soc_put_volsw_sx’:
> sound/soc/soc-core.c:2600: warning: ‘err’ may be used uninitialized in this function
> 
> Acked-by:Brian Austin <brian.austin@cirrus.com>

This should be Signed-off-by (change looks good).

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: core: Initialize err for snd_soc_put_volsw_sx

[Brian Austin]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

On Tue, 3 Apr 2012, Mark Brown wrote:

> On Tue, Apr 03, 2012 at 10:42:32AM -0500, Brian Austin wrote:
>> sound/soc/soc-core.c: In function ‘snd_soc_put_volsw_sx’:
>> sound/soc/soc-core.c:2600: warning: ‘err’ may be used uninitialized in this function
>>
>> Acked-by:Brian Austin <brian.austin@cirrus.com>
>
> This should be Signed-off-by (change looks good).
>
doh!

want me to resend?

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: core: Initialize err for snd_soc_put_volsw_sx

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 144 bytes --]

On Tue, Apr 03, 2012 at 11:24:09AM -0500, Brian Austin wrote:

> want me to resend?

Please (it's easier to apply if I don't need to edit :) ).

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]