* [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE
@ 2012-04-03 20:02 Fabio Estevam
2012-04-03 20:37 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2012-04-03 20:02 UTC (permalink / raw)
To: alsa-devel; +Cc: Fabio Estevam, broonie, Fabio Estevam, kernel
Fix the following warning during kernel boot:
0-000a: 850 <--> 1600 mV at 1200 mV normal
0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/codecs/sgtl5000.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 8e92fb8..bad5ba5 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -87,7 +87,8 @@ static struct regulator_init_data ldo_init_data = {
.min_uV = 850000,
.max_uV = 1600000,
.valid_modes_mask = REGULATOR_MODE_NORMAL,
- .valid_ops_mask = REGULATOR_CHANGE_STATUS,
+ .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE |
+ REGULATOR_CHANGE_STATUS,
},
.num_consumer_supplies = 1,
.consumer_supplies = &ldo_consumer[0],
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE
2012-04-03 20:02 [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE Fabio Estevam
@ 2012-04-03 20:37 ` Mark Brown
2012-04-03 20:43 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2012-04-03 20:37 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, alsa-devel, kernel
[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]
On Tue, Apr 03, 2012 at 05:02:33PM -0300, Fabio Estevam wrote:
> Fix the following warning during kernel boot:
>
> 0-000a: 850 <--> 1600 mV at 1200 mV normal
> 0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE
Are you sure this is the best fix? There's no set_voltage() call in the
driver.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE
2012-04-03 20:37 ` Mark Brown
@ 2012-04-03 20:43 ` Fabio Estevam
2012-04-03 20:44 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2012-04-03 20:43 UTC (permalink / raw)
To: Mark Brown; +Cc: Fabio Estevam, alsa-devel, kernel
On Tue, Apr 3, 2012 at 5:37 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Apr 03, 2012 at 05:02:33PM -0300, Fabio Estevam wrote:
>> Fix the following warning during kernel boot:
>>
>> 0-000a: 850 <--> 1600 mV at 1200 mV normal
>> 0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE
>
> Are you sure this is the best fix? There's no set_voltage() call in the
> driver.
Sorry, I was not able to understand your last comment.
How do you suggest me to fix this, please?
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE
2012-04-03 20:43 ` Fabio Estevam
@ 2012-04-03 20:44 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-04-03 20:44 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, alsa-devel, kernel
[-- Attachment #1.1: Type: text/plain, Size: 488 bytes --]
On Tue, Apr 03, 2012 at 05:43:20PM -0300, Fabio Estevam wrote:
> On Tue, Apr 3, 2012 at 5:37 PM, Mark Brown
> > Are you sure this is the best fix? There's no set_voltage() call in the
> > driver.
> Sorry, I was not able to understand your last comment.
> How do you suggest me to fix this, please?
I was wondering if it might be better to remove the voltage range if the
driver doesn't ever actually set the voltage rather than adding an
unused permission to change it.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-03 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-03 20:02 [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE Fabio Estevam
2012-04-03 20:37 ` Mark Brown
2012-04-03 20:43 ` Fabio Estevam
2012-04-03 20:44 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).