From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, kernel@pengutronix.de
Subject: Re: [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE
Date: Tue, 3 Apr 2012 21:44:57 +0100 [thread overview]
Message-ID: <20120403204457.GC11910@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOMZO5AaqN8aXPwQQbQDopRsx3ndra8SQNkvmxH08HTyiKCORQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 488 bytes --]
On Tue, Apr 03, 2012 at 05:43:20PM -0300, Fabio Estevam wrote:
> On Tue, Apr 3, 2012 at 5:37 PM, Mark Brown
> > Are you sure this is the best fix? There's no set_voltage() call in the
> > driver.
> Sorry, I was not able to understand your last comment.
> How do you suggest me to fix this, please?
I was wondering if it might be better to remove the voltage range if the
driver doesn't ever actually set the voltage rather than adding an
unused permission to change it.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-04-03 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 20:02 [PATCH] ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE Fabio Estevam
2012-04-03 20:37 ` Mark Brown
2012-04-03 20:43 ` Fabio Estevam
2012-04-03 20:44 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403204457.GC11910@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).