alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Rafael <rjw@sisk.pl>, Linux-ALSA <alsa-devel@alsa-project.org>,
	Paul Mundt <lethal@linux-sh.org>, Liam Girdwood <lrg@ti.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH 1/4 v2] ASoC: sh: fsi: add fsi-common-codec card support
Date: Fri, 6 Apr 2012 18:58:49 +0100	[thread overview]
Message-ID: <20120406175848.GN19424@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <87y5qchyqj.wl%kuninori.morimoto.gx@renesas.com>


[-- Attachment #1.1: Type: text/plain, Size: 696 bytes --]

On Tue, Apr 03, 2012 at 10:06:48PM -0700, Kuninori Morimoto wrote:
> Current Linux Kernel is using fsi-xxx card driver for SuperH sound card.
> But the differences between these were only value/strings of setting.
> In order to reduce duplicate driver, this patch adds fsi-common-codec.

So, I've been sitting on this stuff.  The reason is not that there's a
problem but rather the opposite - I can't see anything here that is FSI
specific so really it seems like we should make this available to other
platforms by calling it something like "simple-card" and putting it in
some generic folder (perhaps even called "generic").

This would mean that even more people could benefit from your work.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2012-04-06 17:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02  1:31 [PATCH 0/5] ASoC: sh: fsi-codec Kuninori Morimoto
2012-04-02  1:32 ` [PATCH 1/5] ASoC: sh: fsi: add fsi-codec card support Kuninori Morimoto
2012-04-02 21:39   ` Mark Brown
2012-04-03  0:14     ` Kuninori Morimoto
2012-04-03  2:01       ` Kuninori Morimoto
2012-04-03 12:36         ` Mark Brown
2012-04-02  1:32 ` [PATCH 2/5] ASoC: sh: fsi: remove fsi-ak4642 card driver Kuninori Morimoto
2012-04-02  1:33 ` [PATCH 3/5] ASoC: sh: fsi: remove fsi-hdmi " Kuninori Morimoto
2012-04-02  1:33 ` [PATCH 4/5] ASoC: sh: fsi: remove fsi-da7210 " Kuninori Morimoto
2012-04-02  1:33 ` [PATCH 5/5] ASoC: sh: fsi: add FSI-WM8978 support Kuninori Morimoto
2012-04-02 21:42   ` Mark Brown
2012-04-03  0:50     ` Kuninori Morimoto
2012-04-03  2:02       ` Kuninori Morimoto
2012-04-03 12:31         ` Mark Brown
2012-04-03 12:37       ` Mark Brown
2012-04-04  5:04 ` [PATCH 0/4 v2] ASoC: sh: fsi-codec Kuninori Morimoto
2012-04-04  5:06   ` [PATCH 1/4 v2] ASoC: sh: fsi: add fsi-common-codec card support Kuninori Morimoto
2012-04-06 17:58     ` Mark Brown [this message]
2012-04-09  0:01       ` Kuninori Morimoto
2012-04-09  4:12         ` [PATCH 0/5 v3] ASoC: add simple-card support Kuninori Morimoto
2012-04-09  4:17           ` [PATCH 1/5 v3] ASoC: add generic " Kuninori Morimoto
2012-04-13 10:35             ` Mark Brown
2012-04-16  7:11               ` Kuninori Morimoto
2012-04-16  8:22                 ` Mark Brown
2012-04-16  8:30                   ` Kuninori Morimoto
2012-04-16  9:48                     ` Takashi Iwai
2012-04-16 10:05                       ` Mark Brown
2012-04-16 10:16                         ` Takashi Iwai
2012-04-19  2:54                           ` Kuninori Morimoto
2012-04-19  5:41                             ` Takashi Iwai
2012-04-19  7:00                               ` [PATCH] ALSA: workaround: change the timing of alsa_sound_last_init() Kuninori Morimoto
2012-04-19 11:43                                 ` Mark Brown
2012-04-19 11:52                                 ` Takashi Iwai
2012-04-09  4:18           ` [PATCH 2/5 v3] ASoC: sh: fsi: use simple-card instead of fsi-ak4642 Kuninori Morimoto
2012-04-09  4:18           ` [PATCH 3/5 v3] ASoC: sh: fsi: use simple-card instead of fsi-hdmi Kuninori Morimoto
2012-04-09  4:19           ` [PATCH 4/5 v3] ASoC: sh: fsi: use simple-card instead of fsi-da7210 Kuninori Morimoto
2012-04-09  4:20           ` [PATCH 5/5 v3] ASoC: sh: fsi: select simple-card on Kconfig Kuninori Morimoto
2012-04-04  5:07   ` [PATCH 2/4 v2] ASoC: sh: fsi: use fsi-common-codec instead of fsi-ak4642 Kuninori Morimoto
2012-04-04  5:08   ` [PATCH 3/4 v2] ASoC: sh: fsi: use fsi-common-codec instead of fsi-hdmi Kuninori Morimoto
2012-04-04  5:09   ` [PATCH 4/4 v2] ASoC: sh: fsi: use fsi-common-codec instead of fsi-da7210 Kuninori Morimoto
2012-04-18 10:47   ` [PATCH 0/4 v2] ASoC: sh: fsi-codec Rafael J. Wysocki
2012-04-18 16:58     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120406175848.GN19424@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lethal@linux-sh.org \
    --cc=lrg@ti.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).