From: Dan Carpenter <dan.carpenter@oracle.com>
To: david.henningsson@canonical.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ALSA: hda - Fix internal mic for Lenovo Ideapad U300s
Date: Tue, 10 Apr 2012 11:37:32 +0300 [thread overview]
Message-ID: <20120410083732.GA26832@elgon.mountain> (raw)
Hello David Henningsson,
This is a semi-automatic email about new static checker warnings.
The patch 18dcd3044e4c: "ALSA: hda - Fix internal mic for Lenovo
Ideapad U300s" from Apr 2, 2012, leads to the following Smatch
complaint:
sound/pci/hda/patch_conexant.c:4449 apply_fixup()
error: we previously assumed 'quirk' could be null (see line 4444)
sound/pci/hda/patch_conexant.c
4443 quirk = snd_pci_quirk_lookup(codec->bus->pci, quirk);
4444 if (quirk && table[quirk->value]) {
^^^^^
Old check.
4445 snd_printdd(KERN_INFO "hda_codec: applying pincfg for %s\n",
4446 quirk->name);
4447 apply_pincfg(codec, table[quirk->value]);
4448 }
4449 if (quirk->value == CXT_FIXUP_STEREO_DMIC) {
^^^^^^^^^^^^
New unchecked dereference.
4450 snd_printdd(KERN_INFO "hda_codec: applying internal mic workaround for %s\n",
4451 quirk->name);
regards,
dan carpenter
next reply other threads:[~2012-04-10 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 8:37 Dan Carpenter [this message]
2012-04-10 9:47 ` ALSA: hda - Fix internal mic for Lenovo Ideapad U300s David Henningsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410083732.GA26832@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).