From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: ac97: Fix build due to removal of 'runtime' definition
Date: Wed, 11 Apr 2012 11:43:03 +0100 [thread overview]
Message-ID: <20120411104302.GI3163@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334097504-14729-1-git-send-email-festevam@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 994 bytes --]
On Tue, Apr 10, 2012 at 07:38:23PM -0300, Fabio Estevam wrote:
> This was caused by commit e6968a (ASoC: codecs: Remove rtd->codec usage from CODEC drivers),
> which removed the 'struct snd_pcm_runtime *runtime = substream->runtime' definition.
You're missing what I was saying the other day. What I was looking for
here was something more like "commit e6968a was intended to remove uses
of substream->runtime purely to find the CODEC pointer in order to
support CODEC<->CODEC links but in these cases we're actually using data
directly in the runtime so the removal shouldn't have been done here" -
the thing is to explain what the change did wrong and why this is a good
fix for that. Sometimes this is just that there was a typo but in cases
like this where the initial thought would be "why are we not removing
uses of runtime?" it makes it much easier to see why the fix is good.
It'd also have been good to just re-add the declaration of runtime here.
Anyway, applied both, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-04-11 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 22:38 [PATCH 1/2] ASoC: ac97: Fix build due to removal of 'runtime' definition Fabio Estevam
2012-04-10 22:38 ` [PATCH 2/2] ASoC: wm9705: " Fabio Estevam
2012-04-11 10:43 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411104302.GI3163@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).