From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Brian Austin <brian.austin@cirrus.com>
Cc: mbizon@freebox.fr, alsa-devel@alsa-project.org, lrg@ti.com,
joe@nucleusys.com
Subject: Re: [PATCH] ASoC: Add support for CS42L52 Codec
Date: Tue, 17 Apr 2012 17:07:04 +0100 [thread overview]
Message-ID: <20120417160703.GO6652@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1204171040350.16471@heelrod.ad.cirrus.com>
[-- Attachment #1.1: Type: text/plain, Size: 772 bytes --]
On Tue, Apr 17, 2012 at 10:55:59AM -0500, Brian Austin wrote:
> On Tue, 17 Apr 2012, Mark Brown wrote:
> >On Mon, Apr 16, 2012 at 03:58:58PM -0500, Brian Austin wrote:
> >>+ snd_soc_update_bits(codec, CS42L52_PWRCTL1,
> >>+ CS42L52_PWRCTL1_PDN_CODEC |
> >>+ CS42L52_PWRCTL1_PDN_CHRG, 0);
> >This looks odd, especially having it in _ON - perhaps a comment
> >explaining why?
> I'm just enabling the power for the codec. Are you refering to the
> Charge Pump enable?
Both, really - it's just generally incredibly unusual to have anything
in _ON, and looking at the names these look like supplies for other bits
of the CODEC so things that I'd expect to be turned on early rather than
late in the sequence. If it were in _PREPARE it'd be less surprising.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-04-17 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 20:58 [PATCH] ASoC: Add support for CS42L52 Codec Brian Austin
2012-04-17 11:14 ` Mark Brown
2012-04-17 15:55 ` Brian Austin
2012-04-17 16:07 ` Mark Brown [this message]
2012-04-17 16:25 ` Brian Austin
2012-04-17 16:32 ` Mark Brown
2012-04-17 16:28 ` Brian Austin
2012-04-27 13:44 ` Brian Austin
2012-04-27 13:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417160703.GO6652@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=joe@nucleusys.com \
--cc=lrg@ti.com \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).