* [PATCH v2] ASoC: da7210: Minor update for PLL and SRM
@ 2012-04-17 15:37 Ashish Chavan
2012-04-17 19:53 ` [alsa-devel] " Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Ashish Chavan @ 2012-04-17 15:37 UTC (permalink / raw)
To: Mark Brown, lrg, alsa-devel
Cc: linux-kernel, kuninori.morimoto.gx, David Dajun Chen
This patch converts multiple if conditions in to single if with "&&"s.
Signed-off-by: Ashish Chavan <ashish.chavan@kpitcummins.com>
Signed-off-by: David Dajun Chen <dchen@diasemi.com>
---
Changes since v1:
Aligned '(' s for the branches
---
sound/soc/codecs/da7210.c | 22 +++++++++-------------
1 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index cf4063b..d5fdf17 100644
--- a/sound/soc/codecs/da7210.c
+++ b/sound/soc/codecs/da7210.c
@@ -992,19 +992,15 @@ static int da7210_set_dai_pll(struct snd_soc_dai *codec_dai, int pll_id,
/* Search pll div array for correct divisors */
for (cnt = 0; cnt < ARRAY_SIZE(da7210_pll_div); cnt++) {
- /* check fref */
- if (fref == da7210_pll_div[cnt].fref) {
- /* check mode */
- if (da7210->master == da7210_pll_div[cnt].mode) {
- /* check fout */
- if (fout == da7210_pll_div[cnt].fout) {
- /* all match, pick up divisors */
- pll_div1 = da7210_pll_div[cnt].div1;
- pll_div2 = da7210_pll_div[cnt].div2;
- pll_div3 = da7210_pll_div[cnt].div3;
- break;
- }
- }
+ /* check fref, mode and fout */
+ if ((fref == da7210_pll_div[cnt].fref) &&
+ (da7210->master == da7210_pll_div[cnt].mode) &&
+ (fout == da7210_pll_div[cnt].fout)) {
+ /* all match, pick up divisors */
+ pll_div1 = da7210_pll_div[cnt].div1;
+ pll_div2 = da7210_pll_div[cnt].div2;
+ pll_div3 = da7210_pll_div[cnt].div3;
+ break;
}
}
if (cnt >= ARRAY_SIZE(da7210_pll_div))
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [alsa-devel] [PATCH v2] ASoC: da7210: Minor update for PLL and SRM
2012-04-17 15:37 [PATCH v2] ASoC: da7210: Minor update for PLL and SRM Ashish Chavan
@ 2012-04-17 19:53 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-04-17 19:53 UTC (permalink / raw)
To: Ashish Chavan
Cc: lrg, alsa-devel, David Dajun Chen, kuninori.morimoto.gx,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
On Tue, Apr 17, 2012 at 09:07:44PM +0530, Ashish Chavan wrote:
> This patch converts multiple if conditions in to single if with "&&"s.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-17 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-17 15:37 [PATCH v2] ASoC: da7210: Minor update for PLL and SRM Ashish Chavan
2012-04-17 19:53 ` [alsa-devel] " Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).