From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ola Lilja <ola.o.lilja@stericsson.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 6/8] ASoC: Ux500: Add platform-driver
Date: Mon, 23 Apr 2012 19:31:40 +0100 [thread overview]
Message-ID: <20120423183140.GV8318@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334914394-27518-1-git-send-email-ola.o.lilja@stericsson.com>
[-- Attachment #1.1: Type: text/plain, Size: 869 bytes --]
On Fri, Apr 20, 2012 at 11:33:14AM +0200, Ola Lilja wrote:
> Add platform-driver handling all DMA-activities.
Overall this looks really good, but it depends on the stream print thing
as well. There's a few very nitpicky issues also:
> -config SND_SOC_UX500_MSP_I2S
> +config SND_SOC_UX500_PLAT_MSP_I2S
Should be in the previous patch.
> -snd-soc-ux500-msp-i2s-objs := ux500_msp_dai.o ux500_msp_i2s.o
> -obj-$(CONFIG_SND_SOC_UX500_MSP_I2S) += snd-soc-ux500-msp-i2s.o
> +snd-soc-ux500-plat-msp-i2s-objs := ux500_msp_dai.o ux500_msp_i2s.o
> +obj-$(CONFIG_SND_SOC_UX500_PLAT_MSP_I2S) += snd-soc-ux500-plat-msp-i2s.o
Likewise.
> + dev_dbg(dev, "%s: Init runtime private data.\n", __func__);
> + ux500_pcm_data = kzalloc(sizeof(struct ux500_pcm), GFP_KERNEL);
> + if (ux500_pcm_data == NULL)
> + return -ENOMEM;
> + ux500_pcm_data->msp_id = dai->id;
devm_kzalloc()?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-04-23 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 9:33 [PATCH 6/8] ASoC: Ux500: Add platform-driver Ola Lilja
2012-04-23 18:31 ` Mark Brown [this message]
2012-04-27 8:46 ` Ola Lilja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423183140.GV8318@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linus.walleij@linaro.org \
--cc=lrg@ti.com \
--cc=ola.o.lilja@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).