From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ola Lilja <ola.o.lilja@stericsson.com>
Cc: alsa-devel@alsa-project.org,
Kristoffer KARLSSON <kristoffer.karlsson@stericsson.com>,
Liam Girdwood <lrg@ti.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 2/8] ASoC: core: Add strobe control
Date: Mon, 23 Apr 2012 20:13:02 +0100 [thread overview]
Message-ID: <20120423191302.GZ8318@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334914364-27373-1-git-send-email-ola.o.lilja@stericsson.com>
[-- Attachment #1.1: Type: text/plain, Size: 677 bytes --]
On Fri, Apr 20, 2012 at 11:32:44AM +0200, Ola Lilja wrote:
> From: Kristoffer KARLSSON <kristoffer.karlsson@stericsson.com>
>
> Added support for a control that strobes a bit in
> a register to high then back to low (or the inverse).
I've applied this but...
> + unsigned int val = snd_soc_read(codec, reg) & mask;
> +
> + if (shift != 0 && val != 0)
> + val = val >> shift;
> + ucontrol->value.enumerated.item[0] = val ^ invert;
...it seems weird that the code actually reads back the enumeration
status, even if we're in the middle of strobing it should be a very
brief, transitory, status which it isn't really worth going to the
effort of reporting.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-04-23 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 9:32 [PATCH 2/8] ASoC: core: Add strobe control Ola Lilja
2012-04-23 19:13 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423191302.GZ8318@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=kristoffer.karlsson@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=lrg@ti.com \
--cc=ola.o.lilja@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).