* [PATCH] ASoC: core: Fix dai_link dereference.
@ 2012-04-30 10:05 Liam Girdwood
2012-04-30 10:15 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Liam Girdwood @ 2012-04-30 10:05 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Liam Girdwood
We should check dailess before dereferencing.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Liam Girdwood <lrg@ti.com>
---
sound/soc/soc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 9bdfef4..7f1e012 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1218,7 +1218,7 @@ static int soc_post_component_init(struct snd_soc_card *card,
#ifdef CONFIG_DEBUG_FS
/* add DPCM sysfs entries */
- if (!dai_link->dynamic)
+ if (!dailess && !dai_link->dynamic)
goto out;
ret = soc_dpcm_debugfs_add(rtd);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: core: Fix dai_link dereference.
2012-04-30 10:05 [PATCH] ASoC: core: Fix dai_link dereference Liam Girdwood
@ 2012-04-30 10:15 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-04-30 10:15 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 129 bytes --]
On Mon, Apr 30, 2012 at 11:05:30AM +0100, Liam Girdwood wrote:
> We should check dailess before dereferencing.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-30 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-30 10:05 [PATCH] ASoC: core: Fix dai_link dereference Liam Girdwood
2012-04-30 10:15 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).