From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: Christoph Fritz <chf.fritz@googlemail.com>,
alsa-devel@alsa-project.org,
Sascha Hauer <s.hauer@pengutronix.de>, Liam Girdwood <lrg@ti.com>
Subject: Re: ASoC: wm9712: Microphone doesn't work, "Capture Volume" inverted
Date: Tue, 1 May 2012 18:12:07 +0100 [thread overview]
Message-ID: <20120501171207.GC4089@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120430234458.GB15188@local>
[-- Attachment #1.1: Type: text/plain, Size: 666 bytes --]
On Tue, May 01, 2012 at 01:44:58AM +0200, Hans J. Koch wrote:
> On Mon, Apr 30, 2012 at 10:43:33PM +0100, Mark Brown wrote:
> > I'm not entirely sure you've looked at the code here...
> Oh yes, sorry. I got distracted by your mentioning of the suppressed writes.
> Actually, we have suppressed reads. ac97_read() does a "return cache[reg];"
> for most registers, assuming the hardware register cannot change after a
> ac97_write(). That might or might not be true, to me it looks dangerous.
The driver knows exactly which registers are volatile and takes
advantage of this - this is entirely idiomatic for devices like this and
not really that hard to get right.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-05-01 17:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 20:07 ASoC: wm9712: Microphone doesn't work, "Capture Volume" inverted Christoph Fritz
2012-04-26 10:15 ` Christoph Fritz
2012-04-26 11:27 ` Mark Brown
2012-04-26 13:49 ` Christoph Fritz
2012-04-26 17:20 ` Mark Brown
2012-04-26 21:11 ` Christoph Fritz
2012-04-26 21:37 ` Mark Brown
2012-04-27 8:00 ` Christoph Fritz
2012-04-27 13:46 ` Mark Brown
2012-05-04 13:28 ` Christoph Fritz
2012-05-07 21:55 ` Christoph Fritz
2012-05-08 10:29 ` Christoph Fritz
2012-05-12 0:15 ` ASoC: wm9712: Microphone doesn't work: Mux handling broken? Christoph Fritz
2012-05-12 11:51 ` Mark Brown
2012-05-13 3:56 ` Christoph Fritz
2012-05-15 9:15 ` Christoph Fritz
2012-05-15 17:15 ` Mark Brown
[not found] ` <20120430192258.GA15188@local>
2012-04-30 21:43 ` ASoC: wm9712: Microphone doesn't work, "Capture Volume" inverted Mark Brown
[not found] ` <20120430234458.GB15188@local>
2012-05-01 17:12 ` Mark Brown [this message]
[not found] ` <20120501200755.GF15188@local>
2012-05-01 22:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501171207.GC4089@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=chf.fritz@googlemail.com \
--cc=hjk@hansjkoch.de \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).