From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH] ASoC: twl6040: Support for DT
Date: Tue, 8 May 2012 13:26:31 +0100 [thread overview]
Message-ID: <20120508122630.GM15893@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1336477945-27460-1-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 654 bytes --]
On Tue, May 08, 2012 at 02:52:25PM +0300, Peter Ujfalusi wrote:
> +static const struct of_device_id twl6040_codec_of_match[] = {
> + {.compatible = "ti,twl6040-codec", },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, twl6040_codec_of_match);
Why are we loading MFD components using device tree? It seems like
we're doing something very wrong if we need people to explicitly write
this stuff out in the device tree, the whole MFD thing is purely a Linux
implementation detail, as is the way the interrupt controller has been
structured. I'd really not expect to see a specific node like this,
especially not one that does nothing but device registration.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-05-08 12:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 11:52 [PATCH] ASoC: twl6040: Support for DT Peter Ujfalusi
2012-05-08 12:26 ` Mark Brown [this message]
2012-05-08 12:42 ` Peter Ujfalusi
2012-05-08 13:41 ` Mark Brown
2012-05-09 12:01 ` Peter Ujfalusi
2012-05-09 13:35 ` Mark Brown
2012-05-10 12:55 ` Peter Ujfalusi
2012-05-11 14:05 ` Mark Brown
[not found] ` <20120509133511.GQ3955-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-11 11:02 ` Cousson, Benoit
2012-05-11 13:08 ` Mark Brown
[not found] ` <20120511130816.GB3960-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-11 15:44 ` Cousson, Benoit
2012-05-11 20:34 ` Mark Brown
2012-05-14 11:38 ` Peter Ujfalusi
2012-05-14 12:11 ` Mark Brown
2012-05-15 8:00 ` Peter Ujfalusi
2012-05-14 15:34 ` Tony Lindgren
2012-05-15 7:41 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508122630.GM15893@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).