From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH 4/4] ASoC: omap-abe-twl6040: Add device tree support
Date: Tue, 8 May 2012 14:59:13 +0100 [thread overview]
Message-ID: <20120508135912.GR15893@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1336479314-27766-5-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 900 bytes --]
On Tue, May 08, 2012 at 03:15:14PM +0300, Peter Ujfalusi wrote:
> abe-twl6040,jack_detection = <0>;
Shouldn't this be a boolean property that simply needs to be present to
flag detection?
> dai-link1,codec = <&twl6040_codec>;
> dai-link1,dai = <&mcpdm>;
This seems like it ought to be an array of nodes, one per link, instead
of having an index in the property name. It should certainly be easier
to parse.
It also seems like it's not at all board specific and should be factored
out.
> abe-twl6040,audio-routing =
> "Headset Stereophone", "HSOL",
> "Headset Stereophone", "HSOR",
Binding should document what the board-defined nodes are.
> +Example:
> +
> +sound { /* ASoC */
> + compatible = "ti,abe-twl6040";
> + abe-twl6040,model = "SDP4430";
Please don't repeat your binding documentation in the changelog, it's
already in the patch and means it comes after the documentation.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-05-08 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 12:15 [PATCH 0/4] omap-abe-twl6040: Device tree support Peter Ujfalusi
2012-05-08 12:15 ` [PATCH 1/4] ASoC: omap-abe-twl6040: Keep only one snd_soc_dai_link structure Peter Ujfalusi
2012-05-08 15:52 ` Mark Brown
2012-05-08 12:15 ` [PATCH 2/4] ASoC: omap-abe-twl6040: Move Digital Mic widget into dapm table Peter Ujfalusi
2012-05-08 18:30 ` Mark Brown
2012-05-08 12:15 ` [PATCH 3/4] ASoC: omap-abe-twl6040: Introduce driver data for runtime parameters Peter Ujfalusi
2012-05-08 18:31 ` Mark Brown
2012-05-08 12:15 ` [PATCH 4/4] ASoC: omap-abe-twl6040: Add device tree support Peter Ujfalusi
2012-05-08 13:59 ` Mark Brown [this message]
2012-05-09 11:45 ` Peter Ujfalusi
2012-05-09 15:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508135912.GR15893@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).