alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: fsl: fix the binding of imx-sgtl5000
@ 2012-05-11 14:44 Shawn Guo
  2012-05-11 15:36 ` Tabi Timur-B04825
  2012-05-11 21:52 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Shawn Guo @ 2012-05-11 14:44 UTC (permalink / raw)
  To: alsa-devel; +Cc: Mark Brown, Richard Zhao, linux-arm-kernel, Shawn Guo

The sgtl5000 data sheet does not particularly mention that the Mic Bias
will internally supplies to MIC_IN, so fix the example in imx-sgtl5000
binding document to have a better reflection of the actual circuit.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 .../bindings/sound/imx-audio-sgtl5000.txt          |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/imx-audio-sgtl5000.txt b/Documentation/devicetree/bindings/sound/imx-audio-sgtl5000.txt
index d09b4e3..e4acdd8 100644
--- a/Documentation/devicetree/bindings/sound/imx-audio-sgtl5000.txt
+++ b/Documentation/devicetree/bindings/sound/imx-audio-sgtl5000.txt
@@ -41,8 +41,8 @@ sound {
 	ssi-controller = <&ssi1>;
 	audio-codec = <&sgtl5000>;
 	audio-routing =
+		"MIC_IN", "Mic Jack",
 		"Mic Jack", "Mic Bias",
-		"MIC_IN", "Mic Bias",
 		"Headphone Jack", "HP_OUT";
 	mux-int-port = <1>;
 	mux-ext-port = <3>;
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: fsl: fix the binding of imx-sgtl5000
  2012-05-11 14:44 [PATCH] ASoC: fsl: fix the binding of imx-sgtl5000 Shawn Guo
@ 2012-05-11 15:36 ` Tabi Timur-B04825
  2012-05-11 21:52 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Tabi Timur-B04825 @ 2012-05-11 15:36 UTC (permalink / raw)
  To: Shawn Guo
  Cc: alsa-devel@alsa-project.org, Mark Brown, Zhao Richard-B20223,
	linux-arm-kernel@lists.infradead.org

On Fri, May 11, 2012 at 9:44 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> mention that the Mic Bias
> will internally supplies to MIC_IN

Is there a typo there?  This sentence doesn't make sense to me.

-- 
Timur Tabi
Linux kernel developer at Freescale

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: fsl: fix the binding of imx-sgtl5000
  2012-05-11 14:44 [PATCH] ASoC: fsl: fix the binding of imx-sgtl5000 Shawn Guo
  2012-05-11 15:36 ` Tabi Timur-B04825
@ 2012-05-11 21:52 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-05-11 21:52 UTC (permalink / raw)
  To: Shawn Guo; +Cc: alsa-devel, Richard Zhao, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 294 bytes --]

On Fri, May 11, 2012 at 10:44:23PM +0800, Shawn Guo wrote:
> The sgtl5000 data sheet does not particularly mention that the Mic Bias
> will internally supplies to MIC_IN, so fix the example in imx-sgtl5000
> binding document to have a better reflection of the actual circuit.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-11 21:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-11 14:44 [PATCH] ASoC: fsl: fix the binding of imx-sgtl5000 Shawn Guo
2012-05-11 15:36 ` Tabi Timur-B04825
2012-05-11 21:52 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).