Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Patrick Lai <plai@codeaurora.org>
Cc: alsa-devel <alsa-devel@alsa-project.org>, Liam Girdwood <lrg@ti.com>
Subject: Re: Problem with snd_soc_suspend
Date: Mon, 14 May 2012 09:34:31 +0100	[thread overview]
Message-ID: <20120514083430.GG31985@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FB0A685.3040408@codeaurora.org>


[-- Attachment #1.1: Type: text/plain, Size: 807 bytes --]

On Sun, May 13, 2012 at 11:30:29PM -0700, Patrick Lai wrote:

> that as system attempts to enter suspend while DAILINK X is active,
> snd_soc_suspend() calls snd_soc_dapm_stream_event(
> SND_SOC_DAPM_STREAM_SUSPEND) on inactive DAILINK Y since DAILINK Y
> ignore flag is not set. Consequently, CODEC widgets get powered off
> even though they should remain powered for DAILINK X.

This sounds like expected behaviour, if the widgets aren't marked as
ignoring suspend then they will be suspended.

> 1. Should soc-core check if CODEC DAI is active beside checking
> ignore_suspend flag before calling snd_soc_dapm_stream_event()?
> I checked latest soc-core.c from kernel 3.4 RC7. The logic is the same
> as 3.0

No, the whole point here is to suspend.  If we did that we'd never
suspend any active streams.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2012-05-14  8:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14  6:30 Problem with snd_soc_suspend Patrick Lai
2012-05-14  8:34 ` Mark Brown [this message]
2012-05-17 20:21   ` Patrick Lai
2012-05-17 21:46     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514083430.GG31985@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@ti.com \
    --cc=plai@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox